Hi, If it is simple to back out the change, that's fine.
Another approach is to disable the failing test, and file a JIRA to cover that. Dave -----Original Message----- From: Suresh Subbiah [mailto:[email protected]] Sent: Wednesday, July 6, 2016 5:12 PM To: [email protected] Subject: Re: FYI - Trafodion check tests are failing Hi, Sorry for my mistake in merging the PR prematurely.. I did not notice that the check test had failed. The change seemed safe. Will wait a day for change owner to submit a new change to either backout previous change or fix this issue. At that point I can try to submit a negative of this PR to get the code back to the old state. Sorry for being careless. Thanks Suresh On Wed, Jul 6, 2016 at 5:24 PM, Sandhya Sundaresan < [email protected]> wrote: > Sorry - I think I was trying to say reopen the JIRA -306. Perhaps we > jsutneed to undo the change done for that and addresss it differently. > But will leave that decision o the JIRA owner - whatever is the > quickest to get back on track. > Sandhya > > -----Original Message----- > From: Dave Birdsall [mailto:[email protected]] > Sent: Wednesday, July 6, 2016 3:21 PM > To: [email protected] > Subject: RE: FYI - Trafodion check tests are failing > > Hi, > > There's no such thing as re-opening a PR to my knowledge. The PR has > already been merged. > > Instead, a new PR with the fix must be submitted. > > Dave > > -----Original Message----- > From: Sandhya Sundaresan [mailto:[email protected]] > Sent: Wednesday, July 6, 2016 3:17 PM > To: [email protected] > Subject: FYI - Trafodion check tests are failing > > Hi all, > > Since this PR merge *“[TRAFODION-306] PR-575 LP Bug: 1323868 - ODBC > SQLGetTypeInfo api - all datatypes being returned as BIGINT*”, > Trafodion Check Tests have been failing. > > We need to make sure these tests pass at a minimum before merging in > changes. The PR will be reopened soon and a comment has been added to > it – a fix will be needed ASAP. > > > > For the other failures, > > · executor/TEST022 is being addressed. It was caused by PR 564 > *“**[TRAFODION-1676]support > better runtime error message when a SQL function meet fital error”* > > · The hive failures will be addressed in a PR 574 that is in the > pipeline and soon to be merged. > > · Executor test hang in cdh is a bit tricky and needs more > investigation by TM team. > > > > The Check Tests do need to get addressed ASAP though ( > https://github.com/apache/incubator-trafodion/pull/575 ). > > > > Thanks > > Sandhya >
