Let's start simple: how much did we change in the code we reused? Is a port or is it a large rewrite based on referencing the PostgreSQL code? From what I understand, we're looking at mostly a port, which says that we don't add Apache headers.
Gunnar On Wed, Nov 16, 2016 at 1:54 PM, Steve Varnau <[email protected]> wrote: > That policy is stated at: http://www.apache.org/legal/src-headers.html > And it says that major modifications are handled on a case-by-case basis by > the PMC. > > So the last time this came up, I asked about specific cases on the > incubator general list and it ended up on legal-discuss list. > > https://lists.apache.org/thread.html/d00f72c4aa0b56927dac87b116e2e9 > 2fa32b7dcf447016726683cc4f@1455210877@%3Cgeneral.incubator.apache.org%3E > > --Steve > > > -----Original Message----- > > From: Gunnar Tapper [mailto:[email protected]] > > Sent: Wednesday, November 16, 2016 11:27 AM > > To: [email protected] > > Subject: Re: [DISCUSS] what to do if we are using PostgreSQL code in > > Trafodion > > > > I think the trickiest part of this issue is whether to add the Apache > > license when forking and modifying code. From what I understand, you do > so > > if you've made significant changes only. > > > > "Significant" is a soft term and there's no "if you changed X % of the > > code, then you need to add the ASL." > > > > I recommend that the pull request highlights that the code has been > forked > > for someone else and that an assessment whether to add the Apache > > License > > is needed. > > > > I'll add this guidance to the contributor guide once we've nailed it > down. > > > > Gunnar > > > > On Wed, Nov 16, 2016 at 9:33 AM, Steve Varnau <[email protected]> > > wrote: > > > > > > > > Looks like we dodged a problem by picking up JSON code from postgres > > > rather than re-using some json.org jar files like some other projects. > > > Apache just re-categorized the json.org license from Category A to > > > Category X. So those projects have to change their dependencies before > > > doing another release. > > > > > > --Steve > > > > > > > -----Original Message----- > > > > From: Liu, Ming (Ming) [mailto:[email protected]] > > > > Sent: Tuesday, November 15, 2016 5:15 PM > > > > To: [email protected] > > > > Subject: [DISCUSS] what to do if we are using PostgreSQL code in > > > Trafodion > > > > > > > > Hi, all, > > > > > > > > Some new functions we want to add into Trafodion will depend on code > > that > > > > originally come from PostgreSQL. So we would like to know what to be > > > aware > > > > if we want to add/port source code from other open source project > like > > > > PostgreSQL. > > > > From some discussion with Steve, Hans, Roberta and Gunnar, I get some > > > > very good guidance. I sum it here, and if people have more input, it > > > will help > > > > a lot. > > > > > > > > It is allowed by Apache license to add PostgreSQL code into Apache > > > project: > > > > http://www.apache.org/legal/resolved.html > > > > > > > > Here are some advices to add code from other open source project into > > > > Trafodion (Thanks Steve and Roberta to write this up) : > > > > > > > > 1) When you copy code, you must retain the original copyright or > > > license > > > > statements from that code. > > > > > > > > a. If there were no original license headers in the code, then > it > > > might be a > > > > good idea to put in a comment at very top stating where/when it was > > > copied > > > > from, but there is no standard for that as far as I know. > > > > > > > > 2) You should only add the Apache license header (below the > > > original) if > > > > substantial changes are made from the original. > > > > > > > > 3) You should run RAT tool (instructions are on wiki) to see > what > > > it reports > > > > on the files with postgres headers. If the files end up with both > > > headers, RAT > > > > should not report any problem. > > > > > > > > a. You should only add the files to the .rat_exclude file if > RAT > > > reports them > > > > as a problem. > > > > > > > > b. If so, then you should also add explanation of the file > > > licenses in > > > > RAT_README. > > > > > > > > 4) There should also be a statement in the main LICENSE file(s) > > > indicating > > > > that some of the code is under the postgres license. It should > indicate > > > which > > > > files it applies to and have a copy of that license statement. If > this > > > code is > > > > going into SQL code, it should be added to the > licenses/lic-server-src > > > file, so > > > > when we construct the final LICENSE files, it goes into the right > places. > > > > > > > > 5) as part of releasing the product, a scan of copyright notices > > > should be > > > > performed to make sure all have been addressed in the license file. > > > > > > > > 6) RAT reports are run during builds so if there are issues, the > > > build will fail. > > > > > > > > This may still not be the full checklist, so please share your ideas > > > here in this > > > > discussion if you have suggestions/concerns/objections, etc.. We > wish to > > > > benefit from the open source code instead of reinventing the wheel > > when > > > it > > > > is allowed. > > > > > > > > thanks, > > > > Ming > > > > > > > > > > > -- > > Thanks, > > > > Gunnar > > *If you think you can you can, if you think you can't you're right.* > -- Thanks, Gunnar *If you think you can you can, if you think you can't you're right.*
