Hi Justin,

I've just tried building on my laptop and the build, while successful,
didn't produce the entire slide deck, but just the about me slide.

It looks like the fix for renaming the output file caused this, when I
remove the outputFile parameter it works (after renaming the file).

I've left output from the build in a comment to the PR.

Best regards,
Sönke

On Fri, 17 May 2019 at 00:43, Justin Mclean <[email protected]> wrote:

> Hi,
>
> > 1) It contains stuff (I saw the README.md, clean-deps.sh) that's not
> > included in our repository.
>
> They are in a PR, it just hasn’t been accepted yet. [1]
>
> > 2) It contains the "About me" stuff. We kinda deferred that discussion
> last
> > time but I still think we should make it totally anonymous. Same reasons
> we
> > don't have @author tags
>
> You note I that relocated the copyright statement to NOTICE.
>
> If you look at the read me it contains instructions on how to add your own
> information. the above me page was pulled out of the slide deck and put in
> its own file exactly for that reason. The instructions are:
>
> First edit the author, email and position information found in the title
> slide ot the top of slide content file here:
> ./src/main/asciidoc/index.adoc
> Then edit the information that will appear in the about me slide found
> here:
> ./src/main/asciidoc/aboutme.adoc
>
> But if you want me to change this:
> :author: Justin Mclean
> :email: [email protected]
> :position: V.P. Apache Incubator
>
> To:
> :author: Your Name goes here
> :email: Your email address
> :position: Your job title
>
> I have no issue with that.
>
> Thanks,
> Justin
>
> 1. https://github.com/apache/incubator-training/pull/11



-- 
Sönke Liebau
Partner
Tel. +49 179 7940878
OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany

Reply via email to