Hi Regarding the change that Justin recommended: I made the change in my fork and it is already visible in the PR : https://github.com/apache/incubator-training/pull/15
Regards Oli -----Ursprüngliche Nachricht----- Von: Sönke Liebau <[email protected]> Gesendet: Donnerstag, 23. Mai 2019 14:42 An: [email protected] Betreff: Re: Workflow for changing PRs I've tried this with Oli earlier today and was able to create a PR against his branch. We left out the final step of merging it because I only made nonsensical changes, but that should have worked I think. Regarding CTR/RTC - I think there is no perfect, but that shouldn't stop us from trying :) But I do feel that with RTC and our exception for "trivial" changes to bypass review we should be able to find a working model that more or less works for most people. Probably need to try it for a bit and then revisit with the benefit of hindsight. Best regards, Sönke On Thu, 23 May 2019 at 14:27, Justin Mclean <[email protected]> wrote: > Hi, > > > But permissions would of course only be checked later, so I probably > didn't > > proceed far enough to fail :) > > I’ll try agin ion the weekend. > > > Regarding CTR vs RTC, it might make this case a bit easier to handle > > than it currently is, but at the cost of less control for many other cases. > > > > If you are really unhappy with RTC, we can of course revisit that > > discussion and maybe come up with a compromise that makes everybody > happy.. > > Not unhappy, was just pointing out it would of been easier. Easier is > not alway better, > > Thanks, > Justin -- Sönke Liebau Partner Tel. +49 179 7940878 OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
smime.p7s
Description: S/MIME cryptographic signature
