Hi, from a very brief review, I find this change as a useful contribution. I'll adapt Ignite pom once this commit is in master.
Sincerely, Dmitriy Pavlov вт, 4 июн. 2019 г. в 15:50, Sönke Liebau <[email protected] >: > Hi Chris, > > that sounds like a good idea I think. > Back when I fixed the filename thing I briefly played around with this [1] > and it looked to work at a first glance. > The individual poms seem to be much shorter with this. > > Happy to package that as a PR if it doesn't violate the top ten golden > maven rules - I am not the worlds largest maven expert. > > Best regards, > Sönke > > > [1] > > https://github.com/opencore/incubator-training/commit/5ba5e705f1676b48f3922f4e35ba72853c93af86 > > > > On Tue, 28 May 2019 at 10:27, Christofer Dutz <[email protected]> > wrote: > > > Hi all, > > > > one thing we could do, would be to have a shared assets maven module, in > > which we could also pre-assemble the reveal.js stuff, the CSS, the static > > resources and stuff like that and to have > > the presentation specific stuff in the presentations themselves. Then all > > we would have to do, would be to overlay (fetch and unpack) the current > > output directory with stuff from the shared-assets module. > > This would reduce the duplication of image and other resources, would > > allow central adjustment of resources and simplify the build of > > presentations (no need to download and copy all sorts of things). > > > > Chris > > > > Am 26.05.19, 21:16 schrieb "Dmitriy Pavlov" <[email protected]>: > > > > Hi, > > > > I definitely agree we need to share. > > > > I working on Ignite slides and I had to copy-paste apache.css theme. > > Probably we should create a common or shared folder and replace links > > from > > training modules to a shared one. > > > > One more thing I concerned about is our poms. I had to copy-paste a > > number > > of maven dependencies and its setup. Probably we should create some > > parent > > module for slides in a common folder and move some duplicated XML > > there. > > > > Sincerely, > > Dmitriy Pavlov > > > > P.S. POM may look like following > > > > <!-- Copy the normal resources into the root of the slides directory > > --> > > <resource> > > <directory>src/main/resources</directory> > > <targetPath>${project.slides.directory}</targetPath> > > </resource> > > > > <!-- Copy the shared resources into the root of the slides directory > > --> > > <resource> > > <directory>../../shared/assets/resources</directory> > > <targetPath>${project.slides.directory}</targetPath> > > </resource> > > > > > > пт, 17 мая 2019 г. в 13:19, Lars Francke <[email protected]>: > > > > > Hi, > > > > > > a technical question: I'm about to submit the ZooKeeper slides for > > review > > > and I've used the ApacheLogo.png file from the > > NavigatingASFIncubation > > > content. > > > > > > I assume this is going to happen over and over that we have assets > to > > > share. > > > > > > Is there any easy way to have them in a shared content/assets > folder > > or > > > something like that? > > > > > > Cheers, > > > Lars > > > > > > > > > > > -- > Sönke Liebau > Partner > Tel. +49 179 7940878 > OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany >
