Hi Justin, apart from what Lars already mentioned this looks good to me.
I looked at the following items: - Signature and Hash check out - License headers are present in all files (apart from Readme which is unnecessary) - License,Header and Disclaimer are present and look correct - release files have "incubating" in the names - no binaries present - built the presentation and clicked through it +1 from me Best, Sönke On Wed, 23 Oct 2019 at 17:51, Lars Francke <[email protected]> wrote: > Hi Justin, > > I finally got around to take a look at this. > > Some comments: > > - The source tarball contains DS_Store files > - The "There's not one right answer" slide has wrong Asciidoc syntax so the > notes don't work > > Other than that it looks good to me. I'm fine releasing it like that so +1 > from me > > Cheers, > Lars > > > On Thu, Oct 17, 2019 at 10:21 PM Dmitriy Pavlov <[email protected]> > wrote: > > > Hi Austin, > > > > AFAIK, in the Apache each vote matters. Each community decides which > votes > > are counted. > > > > The general rule in Apache: there should be at least 3 +1 votes from PMC > > and more +1 than -1. So each +1 is a confirmation from community members > > that release is ok. So I always encourage everyone to participate. > > > > Sincerely, > > Dmitriy Pavlov > > > > > > чт, 17 окт. 2019 г. в 22:16, Austin Bennett <[email protected] > >: > > > > > I'm not PMC so not sure vote means much other than symbolic. > > > > > > I'd be happy to help check the release, but not quite sure what that > > would > > > look like in this context (then I think ahead to writing tests for such > > > things, which I'm not likely to implement anytime soon). > > > > > > On Thu, Oct 17, 2019 at 11:06 AM Dmitriy Pavlov <[email protected]> > > > wrote: > > > > > > > Hi Justin, > > > > > > > > This is on my list, as well. I don't have a good excuse for not doing > > > that > > > > (except the last 3-4 weeks were unusually hectic). > > > > > > > > I'm absolutely sure that release is OK, but I prefer to double-check > > > before > > > > casting my upvote. > > > > > > > > Sincerely, > > > > Dmitriy Pavlov > > > > > > > > > > > > чт, 17 окт. 2019 г. в 11:57, Lars Francke <[email protected]>: > > > > > > > > > I'm sorry Justin, I just have no time to spare at the moment. We'll > > see > > > > > each other next week in Berlin, let's try and sit together then? > > > > > > > > > > On Thu, Oct 17, 2019 at 9:54 AM Justin Mclean < > > > [email protected]> > > > > > wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > > +1 Thanks for fixing and clarifying Justin. > > > > > > > > > > > > Thanks for your +1. Can other Mentors and PPMC members please > vote, > > > as > > > > > > tehi vote has been open for far too long. > > > > > > > > > > > > Thanks, > > > > > > Justin > > > > > > > > > > > > > > > -- Sönke Liebau Partner Tel. +49 179 7940878 OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
