Looks great!! +1 from my side as well (Not sure if it counts as a vote) thanks for taking care of it. Gautam
On Sun, Sep 13, 2020 at 2:11 AM Christofer Dutz <[email protected]> wrote: > Ping?!? > > How about voting? > > Chris > ________________________________ > Von: Christofer Dutz <[email protected]> > Gesendet: Freitag, 11. September 2020 15:20 > An: [email protected] <[email protected]> > Betreff: Re: [DISCUSS] Apache Training (Incubating) Tools 1.0.0 RC2 > > Thanks for finding this little issue ... > > I wonder why I didn't ... I usually do a full-text-search for SNAPSHOT. > But I also agree that I wouldn't do a RC3 based on only this ... > we need to be sure to document the version correctly on the website. > > Chris > > > Am 11.09.20, 15:00 schrieb "Ryan Skraba" <[email protected]>: > > Hello! I checked the release and it looks OK to me! > > The source bundle at > > tools/1.0.0/rc2/apache-training-incubating-tools-1.0.0-source-release.zip > * matches github at the tag releases/tools/1.0.0 > (15513a9b48f94f389678107e0e59dc1b7359ef44) > * is correctly signed with a key from the KEYS file, and matches the > fingerprint of [email protected] from the apache LDAP > * has a correct sha512 digest > > I can correctly build the three expected artifacts from that source. > > The staging nexus has the three expected artifacts. I checked a > couple of the signed artifacts. > > I built a new demo presentation using the 1.0.0 RC2 archetype and it > seemed OK. > > One *minor* observation, there's a leftover mention of 1.0.0-SNAPSHOT > in tools/content-archetype/README.md If (for some reason) there's an > RC3, it should be fixed, but I wouldn't block the RC2 just for that! > > Anyway, I'm not sure if a non-PMC vote is binding or non-binding, but > it's a +1 for me! Thanks for doing this work, it's looking pretty > tidy! > > Ryan > > > > On Fri, Sep 11, 2020 at 11:08 AM Christofer Dutz > <[email protected]> wrote: > > > > By the way .... there is still a vote open ... it should be a super > quick one ... as the source bundle contains almost nothing ;-) > > > > Chris > > > > > > > > Am 09.09.20, 16:21 schrieb "Christofer Dutz" < > [email protected]>: > > > > As a test, I updated the tools version in all slides to the > current 1.0.0 and all compiled nicely ... > > > > Chris > > > > Am 09.09.20, 15:54 schrieb "Christofer Dutz" < > [email protected]>: > > > > And again … the discussion thread for the ongoing release. > > > > Chris > > > > > >
