Ok … So, I’ve applied 1 and 2 … not quite sure I understand your proposal for and where should these files (and probably their dependencies be moved to? A new module?)
Please inspect: https://github.com/apache/tsfile/pull/11 and possibly help with the last changes. The PR is from within the TsFile reop so anyone can commit to it. Chris Von: Jialin Qiao <[email protected]> Datum: Freitag, 5. Januar 2024 um 13:56 An: [email protected] <[email protected]> Betreff: Re: Some things I came across while renaming the packages Hi, 1. two patents could be moved ot TsFile 201711384490X: Columnar storage for time series 201711319331.1：TS2DIFF encoding 2. could be renamed to LZ4Compressor 3. Just removing the reading from config file, users should set the Config in code when using TsFile SDK. 4. Yes, these module could be moved to TsFile. Jialin Qiao Yuan Tian <[email protected]> 于2024年1月5日周五 20:40写道： > > Hi Chris, > > * Which of the Patents in the NOTICE file apply to TsFile? ----------- > I've no idea.... > * Should the IOTDBLZ4Compressor be renamed? ------------ I think it > should be renamed to TsFileLZ4Compressor > * TSFileConfig is using “iotdb-common.properties” I guess this should > probably be renamed too, right? ----------------- I think this should be > renamed, but it's used by default in iotdb, so before we rename it, we > should also do some changes in iotdb, we need to read these Config and pass > that to TsFileConfig instead of directly reading config from a config file. > * TSFileConfig seems to reference some IoTDB types in string > constants ------------ I found some of these constants belong to > `hadoop-tsfile`, I think module `hadoop-tsfile`, `flink-tsfile-connector`, > `spark-tsfile` should all be moved to tsfile project. > > > > > Best regards, > -------------------------- > Yuan Tian > > > On Fri, Jan 5, 2024 at 8:22 PM Christofer Dutz <[email protected]> > wrote: > > > Hi all, > > > > here are some questions that came up during my renaming of the packages. > > > > > > * Which of the Patents in the NOTICE file apply to TsFile? > > * Should the IOTDBLZ4Compressor be renamed? > > * TSFileConfig is using “iotdb-common.properties” I guess this should > > probably be renamed too, right? > > * TSFileConfig seems to reference some IoTDB types in string constants > > > > So far that was all that I noticed. > > > > Chris > >
