Öhm, I can easily commit do master in IoTDB and think I have even done so in the past.
The fear of crashing the CI is also more of a theoretic one, right? Cause in the past it has been me complaining that nobody is paying any attention to the CI crashing ;-) So, assuming we cared about the CI working flawlessly and assuming we would only hit the merge button, if the build was successful in the branch, then I would agree with you. Knowing that’s not the case, I wouldn’t like to put on the protection. Chris Von: Tian Jiang <[email protected]> Datum: Mittwoch, 17. April 2024 um 13:16 An: [email protected] <[email protected]> Betreff: Re:AW: Unprotected develop branch I thought it was like the master branch in IoTDB. My concern is that if some unreviewed commits are pushed directly onto this branch, the CI may crash, which will cause trouble for other developers. Tian Jiang At 2024-04-17 19:06:37, "Christofer Dutz" <[email protected]> wrote: >Why should develop be protected? > >That’s the branch we do normal development on. > >The release branch should probably be protected. > >Chris > > >Von: Tian Jiang <[email protected]> >Datum: Mittwoch, 17. April 2024 um 12:33 >An: [email protected] <[email protected]> >Betreff: Unprotected develop branch >Greetings, > > >I accidentally pushed a commit directly onto the develop branch a few days ago >and, of course, reverted the commit as soon as I found out. > > >I think the develop branch should be protected to avoid such misoperations. >Can someone with the authorization (Chris I guess) do that? > > >Best regards, >Tian Jiang
