Thanks for bringing up discussions here, Yiheng! I think we need to discuss the whole workflow with more details (could be separated thread), such as "how to contribute", "how to commit". Without consensus and documented, it would be all messed up.
Thanks, Junping Saisai Shao <sai.sai.s...@gmail.com> 于2020年1月8日周三 上午11:49写道： > I agreed, I think there should a wiki about "how to contribute". > > Also about the commit log, I think we should use the script to formalize > the commit log and use this to merge, not directly using GH button, one > consideration is to formalize the commit log, another is to avoid > additional merge commit. Here is what Spark community does ( > https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py) . > > Thanks > Saisai > > Yiheng Wang <yihe...@gmail.com> 于2020年1月8日周三 上午11:38写道： > > > Hi community > > > > I've noticed that PR titles are little causal. For example: > > > > - optimization for delete unnecessary code > > - TUBEMQ-7: Using StringBuilder instead of StringBuffer in BaseResult > > > > Should we consider follow common Apache project pattern, like: > > [TUBEMQ-XXX] PR description > > or > > [TUBEMQ-XXX][Component] PR description > > > > Thanks > > Yiheng > > >
