gosonzhang commented on a change in pull request #44: [TUBEMQ-57] fix some
typos & todo
URL: https://github.com/apache/incubator-tubemq/pull/44#discussion_r403798248
##########
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/master/web/action/screen/Webapi.java
##########
@@ -191,8 +191,8 @@ private StringBuilder
processModifyOperate(HttpServletRequest req, final String
BrokerConfManage brokerConfManage = this.master.getMasterTopicManage();
if ("admin_add_broker_configure".equals(method)) {
strBuffer =
webBrokerDefConfHandler.adminAddBrokerDefConfEntityInfo(req);
- } else if ("admin_bath_add_broker_configure".equals(method)) {
Review comment:
First of all, thanks @Technoboy- for finding so many problems!
Then, because the token string of the method has been released to the
public, the modifications in webapi.java are correct, but they will lead to
incompatibility, so, these parts can't be modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services