[
https://issues.apache.org/jira/browse/TUBEMQ-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083781#comment-17083781
]
Aloys Zhang edited comment on TUBEMQ-66 at 4/15/20, 4:15 AM:
-------------------------------------------------------------
[~technoboy] Thanks for your working, I agress with you about shuwdown for
N+1 times.
So, after talking with [~gosonzhang], is there any conclusion for this problem?
was (Author: aloyszhang):
[~technoboy]Thanks for your working, I agress with you about shuwdown for N+1
times.
So, after talking with [~gosonzhang], is there any conclusion for this problem?
> TubeSingleSessionFactory shutdown bug
> -------------------------------------
>
> Key: TUBEMQ-66
> URL: https://issues.apache.org/jira/browse/TUBEMQ-66
> Project: Apache TubeMQ
> Issue Type: Bug
> Reporter: Guo Jiwei
> Assignee: Guo Jiwei
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> 1. TubeSingleSessionFactory could not shutdown
> due to we increase referenceCounter one more time after first constructor
> method:
> {code:java}
> public TubeSingleSessionFactory(final TubeClientConfig tubeClientConfig)
> throws TubeClientException {
> if (referenceCounter.incrementAndGet() == 1) {
> RpcConfig config =
> TubeClientConfigUtils.getRpcConfigByClientConfig(tubeClientConfig, true);
> clientFactory.configure(config);
> //#1
> referenceCounter.incrementAndGet();
> baseSessionFactory = new TubeBaseSessionFactory(clientFactory,
> tubeClientConfig);
> }
> }
> {code}
> We should remove #1
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
