gosonzhang commented on a change in pull request #56: [TUBEMQ-73] fix crc32
checksum in broker & remove duplicate codes
URL: https://github.com/apache/incubator-tubemq/pull/56#discussion_r410522575
##########
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/BrokerServiceServer.java
##########
@@ -673,7 +673,7 @@ public SendMessageResponseB2P
sendMessageP2B(SendMessageRequestP2B request,
final MessageStore store =
this.storeManager.getOrCreateMessageStore(reqTopic,
partition);
final long messageId = this.idWorker.nextId();
- if (store.appendMsg(messageId, dataLength, checkSum, msgData,
+ if (store.appendMsg(messageId, dataLength, request.getCheckSum(),
msgData,
Review comment:
This place needs to be reserved. Even if the client does not do CRC, it
needs to check whether it is consistent with the storage during consumption.
After removal, this logic will be lost
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
