gosonzhang commented on a change in pull request #64:
URL: https://github.com/apache/incubator-tubemq/pull/64#discussion_r415542589
##########
File path:
tubemq-server/src/main/java/org/apache/tubemq/server/broker/msgstore/MessageStoreManager.java
##########
@@ -703,7 +703,7 @@ public void run() {
.append(tubeConfig.getLogClearupDurationMs()).toString());
sBuilder.delete(0, sBuilder.length());
}
- if (!expiredTopic.isEmpty()) {
+ if (expiredTopic.isEmpty()) {
Review comment:
I agree with @aloyszhang ‘s view. If this place is judged to be empty,
not only will the previous end-of-print mark for deleting the file log printing
be lost, but also the useless printing log will increase(most of the time, the
expired file check returns empty).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
