gosonzhang commented on a change in pull request #97:
URL: https://github.com/apache/incubator-tubemq/pull/97#discussion_r431195106
##########
File path:
tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/AddressUtils.java
##########
@@ -34,31 +39,33 @@ public static synchronized String getLocalAddress() throws
Exception {
return localIPAddress;
}
- public static boolean validLocalIp(String currLocalHost) throws Exception {
+ public static synchronized void setLocalAddress(String localIPAddress) {
+ AddressUtils.localIPAddress = localIPAddress;
+ }
+
+ public static boolean validLocalIp(String currLocalHost) {
Review comment:
The validLocalIp function seems to be superfluous and should be removed
along with the sub-functions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
