[ 
https://issues.apache.org/jira/browse/TUBEMQ-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120585#comment-17120585
 ] 

Ping Yu commented on TUBEMQ-166:
--------------------------------

Got it. PTAL at the following:

Changes list:
 * {{bdbRepGroupName         --> [replication].repGroupName}}
 * {{bdbNodeName             --> [replication].repNodeName}}
 * {{bdbNodePort             --> [replication].repNodePort}}
 * {{bdbHelperHost           --> [replication].repHelperHost}}
 * {{bdbEnvHome              --> [master].metaDataPath}}
 * {{bdbLocalSync            --> [{{replication}}].metaLocalSyncPolicy}}
 * {{bdbReplicaSync          --> [{{replication}}].metaReplicaSyncPolicy}}
 * {{bdbReplicaAck           --> [replication].repReplicaAckPolicy}}
 * {{bdbStatusCheckTimeoutMs --> [replication].repStatusCheckTimeoutMs}}

See [link 
this|[https://github.com/pingyu/incubator-tubemq/blob/tubemq166-hide-bdb-configs/conf/master.ini]]
 for detail.

 

Related Docs:
 * docs/tubemq_config_introduction.md
 * docs/tubemq_user_guide.md
 * docs/tubemq_config_introduction_cn.doc (will we rewrite this as markdown ?)
 * docs/tubemq_user_guide_cn.doc (configs in screen shots... a little trouble)

 

Besides, I would do the following:
 * [bdbStore] section and all inner configs are still supported, but will be 
ignored when [replication] exists.
 * Print a warning in master.log about "deprecated blah blah" while [bdbStore] 
is using.

 

> Hide `bdbStore` configs in master.ini
> -------------------------------------
>
>                 Key: TUBEMQ-166
>                 URL: https://issues.apache.org/jira/browse/TUBEMQ-166
>             Project: Apache TubeMQ
>          Issue Type: Improvement
>            Reporter: Ping Yu
>            Assignee: Ping Yu
>            Priority: Major
>             Fix For: 0.5.0
>
>
> I was quit confused when I saw the `[bdbStore]` section in `master.ini`.
> After read some codes and intro of "Oracle Berkeley DB Java Edition", I 
> realized that `bdbStore` is the embedded database, used for meta data 
> storage, and replication between masters. (Am I right ?)
> I suggest that hiding `bdbStore` configs in `master.ini`, as `bdb` is an 
> implementation detail, better not to bother users.
> Necessary configs for `bdbStore` can be renamed to another ones, to be more 
> reasonable.
> E.g. `bdbNodePort` rename to `replicationPort` in `[master]` section.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to