[
https://issues.apache.org/jira/browse/TUBEMQ-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated TUBEMQ-90:
---------------------------------
Labels: pull-request-available (was: )
> Remove unused codes in TubeBroker
> ---------------------------------
>
> Key: TUBEMQ-90
> URL: https://issues.apache.org/jira/browse/TUBEMQ-90
> Project: Apache TubeMQ
> Issue Type: Improvement
> Reporter: Guo Jiwei
> Assignee: Guo Jiwei
> Priority: Normal
> Labels: pull-request-available
>
> 1. TubeBroker implements Runnable interface, I think this is a little
> strange. If we have some extra work to do , we can create inner thread for
> it.
> 2. JVMClusterUtil is useless . If we support start more than one broker in
> one JVM, we have to change some params, we can't set different params for
> different brokers at the same time. And as we will support docker in the
> future, we decide to remove this class.
> 3. remove synchronized in start method.
> 4. remove below codes in stop method
> {code:java}
> if (this.shutdown.get()) {
> return;
> }
> {code}
> 5. remove unused run method.
> 6. remove unused waitForServerOnline method.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
