cku328 commented on a change in pull request #32:
URL:
https://github.com/apache/incubator-tubemq-website/pull/32#discussion_r437119015
##########
File path: docs/en-us/architecture.md
##########
@@ -1,3 +1,7 @@
+---
+title: Architecture - Apache TubeMQ
+---
Review comment:
@wf123537200 Do you mean the title doesn't need to include `Apache
TubeMQ` suffix?
##########
File path: docs/en-us/architecture.md
##########
@@ -1,3 +1,7 @@
+---
+title: Architecture - Apache TubeMQ
+---
Review comment:
If adding title metadata to the document is cumbersome, an even more
extreme approach is to modify the template file to define the title tag
directly as a specified string like "Apache TubeMQ".
I think that would solve this issue as well, but I don't think it's
appropriate considering the search engine optimization.
What do you guys think?
##########
File path: docs/en-us/architecture.md
##########
@@ -1,3 +1,7 @@
+---
+title: Architecture - Apache TubeMQ
+---
Review comment:
If adding title metadata to docs is cumbersome, an even more extreme
approach is to modify the template file to define the title tag directly as a
specified string like "Apache TubeMQ".
I think that would solve this issue as well, but I don't think it's
appropriate considering the search engine optimization.
What do you guys think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]