[ 
https://issues.apache.org/jira/browse/TUBEMQ-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guocheng Zhang resolved TUBEMQ-446.
-----------------------------------
    Fix Version/s: 0.8.0
       Resolution: Fixed

> Small bugs fix that do not affect the main logics
> -------------------------------------------------
>
>                 Key: TUBEMQ-446
>                 URL: https://issues.apache.org/jira/browse/TUBEMQ-446
>             Project: Apache TubeMQ
>          Issue Type: Bug
>            Reporter: Guocheng Zhang
>            Assignee: Guocheng Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>         Attachments: image-2020-12-09-18-53-02-498.png, 
> image-2020-12-09-18-53-55-711.png, image-2020-12-09-20-04-14-698.png
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Found some small bugs
>  1. AddressUtils.getIPV4LocalAddress() should first check whether 
> localIPAddress has been set, and use it directly under the premise that it 
> has been set to reduce unnecessary get operations, locate: 
> [https://github.com/apache/incubator-tubemq/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/AddressUtils.java#L146]
> !image-2020-12-09-18-53-02-498.png!
> 2. The fetchCount parameter in MessageConsumerExample may be negative, so the 
> executorService object should not use fetchCount as the initial value, 
> locate:[https://github.com/apache/incubator-tubemq/blob/master/tubemq-example/src/main/java/org/apache/tubemq/example/MessageConsumerExample.java#L99]
> !image-2020-12-09-18-53-55-711.png!
>  
> 3. Remove the useless parameter WITHOUTDELAY:
> !image-2020-12-09-20-04-14-698.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to