Hi Thomas,
It sounds like you recommending then that we get rid of
input.encoding=<user defined> completely from the TR.props config. Is
that correct? It has been in there since 2.3.x days
I searched through the code base and the method call to
Turbine.getDeafultInputEncoding() is never referenced anywhere currently
except in one test case. The DefaultTurbineRunData.getDefaultCharSet()
currently pulls from Turbine configuration constants, and without the
current patch, this value never gets updated by the user defined property.
It would make more sense to me that it should be handled as you mention
below, but I am not sure where to start to make all the fixes required.
Similar issues exist around updating the default locale.
If we were to get rid of it completely, do you agree UTF-8 should be the
new default or are there reasons it should be something else? How do we
handle modifying the default locale to also conform?
I could not move to Turbine 4.0 without UTF-8 support, and this fix
allows for it. Seems a bit clunky to have to set it manually the way I
have done though. Open to your thoughts/suggestions on a better way
forward :-)
Thanks,
Jeff
On 12/08/2017 10:52 AM, Thomas Vandahl wrote:
On 06.12.17 17:51, pain...@apache.org wrote:
Author: painter
Date: Wed Dec 6 16:51:52 2017
New Revision: 1817310
URL: http://svn.apache.org/viewvc?rev=1817310&view=rev
Log:
Set the configuration parameter to honor the value given by the user in TR.props
-1
This change will only cause confusion.
We should remove the configuration setting then completely (as you will
be overwriting it in any case) and rely on
Turbine.getDefaultInputEncoding() only (making this static).
Bye, Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@turbine.apache.org
For additional commands, e-mail: dev-h...@turbine.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@turbine.apache.org
For additional commands, e-mail: dev-h...@turbine.apache.org
