Hi Turbine Devs,

I think I could finally close up voting, after extending voting  time  for 
another week. 

Casted votes are:

+1 Georg Kallidis
+1 Thomas Vandahl
+1 Jeffery Painter.

With three +1 the RC is ready for a release.

I will fix all the required changes in the repo  and finally publish the 
artifacts. 

Thanks to all the voters!!

Best regards, 

Georg

-----Ursprüngliche Nachricht-----
Von: Kallidis, Georg <georg.kalli...@fu-berlin.de> 
Gesendet: Montag, 30. September 2024 12:26
An: 'Turbine Developers List' <dev@turbine.apache.org>
Betreff: AW: [VOTE] Release candidate fulcrum-yaafi v2.0.1 based on staged 
repository

Hi Jeffery,

yes, I did override the site-plugin version, if I read the commit 
267dff15af387fbc5cd94b943bd02ee40fc7e421 in the last parent version 13 due to a 
requirement to use a new fluido skin.
I apparently missed this failure, which I fixed only in the current parent v14 
in Turbine-core and site modules by duplicating the skin element in the new 
site.xml while at the same time using the new site 2.0.0 schema.
 
The question is, if we could skip this for now. Reading 
https://www.apache.org/legal/release-policy.html#approving-a-release it says 
about source packages :
Every ASF release MUST contain one or more source packages, which MUST be 
sufficient for a user to build and test the release provided they have access 
to the appropriate platform and tools

The source package of this release does contain only Java classes and we could 
pass this, if it is sufficient, that those packages compile and run (as 
expected).

On the other side the site xml has the ASF license header and we currently know 
that is does not run the site building. 

That is it might not be hard condition to stop the release, as building the 
site is not required for the published release sources and we might want to fix 
this later or we want to cancel this release candidate and and build another 
one.

I wait yet for more comments about this and will proceed with this release 
candidate only after a certain amount of time (couple of days) with no 
complaints. 

We will have to do this fix then in the next release at the latest. 

Thanks for your patience!

Wit best regards,

Georg


-----Ursprüngliche Nachricht-----
Von: Jeffery Painter <j...@jivecast.com>
Gesendet: Samstag, 28. September 2024 16:20
An: dev@turbine.apache.org
Betreff: Re: [VOTE] Release candidate fulcrum-yaafi v2.0.1 based on staged 
repository

Hi Georg,

My vote below:

[x] +1 release it


Note, that the site build is broken, but otherwise everything appears to be 
fine. I don't think this is blocking from release.


painter@merlin:~/apache/git/turbine-fulcrum-yaafi$ mvn -version Apache Maven 
3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: /usr/java/maven
Java version: 17.0.9, vendor: Oracle Corporation, runtime: /usr/java/jdk-17.0.9 
Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: 
"6.8.0-45-generic", arch: "amd64", family: "unix"

$ mvn clean install

...

[INFO] --- install:3.1.2:install (default-install) @ fulcrum-yaafi --- [INFO] 
Installing /home/painter/apache/git/turbine-fulcrum-yaafi/pom.xml to 
/home/painter/.m2/repository/org/apache/fulcrum/fulcrum-yaafi/2.0.2-SNAPSHOT/fulcrum-yaafi-2.0.2-SNAPSHOT.pom
[INFO] Installing 
/home/painter/apache/git/turbine-fulcrum-yaafi/target/fulcrum-yaafi-2.0.2-SNAPSHOT.jar
 to 
/home/painter/.m2/repository/org/apache/fulcrum/fulcrum-yaafi/2.0.2-SNAPSHOT/fulcrum-yaafi-2.0.2-SNAPSHOT.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  9.663 s
[INFO] Finished at: 2024-09-28T10:19:03-04:00 [INFO] 
------------------------------------------------------------------------


However,

$ mvn site

...

[INFO] Relativizing site links with respect to localized project URL: 
http://turbine.apache.org/fulcrum/fulcrum-yaafi
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  14.097 s
[INFO] Finished at: 2024-09-28T10:17:34-04:00 [INFO] 
------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-site-plugin:4.0.0-M16:site (default-site) on 
project fulcrum-yaafi: Execution default-site of goal 
org.apache.maven.plugins:maven-site-plugin:4.0.0-M16:site failed: skin cannot 
be null -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, 
re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException


On 9/11/24 10:43, Kallidis, Georg wrote:
> Hi Turbine devs,
>
> a new Turbine Yaafi release candidate has been prepared.
>
> Tag: fulcrum-yaafi-2.0.1-candidate
>
> Git repo (mirrored): 
> https://gitbox.apache.org/repos/asf/turbine-fulcrum-yaafi.git
> Mirror: https://github.com/apache/turbine-fulcrum-yaafi
>
> Update or clone the repo, then checkout the candidate :
>
> git checkout fulcrum-yaafi-2.0.1-candidate
>
> N.B. If you do a checkout for a tag, you are in detached head mode, as 
> you
>
> have no branch to work on.
>
> Artifacts:
>
> https://repository.apache.org/content/repositories/orgapacheturbine-10
> 89/
>
>
> Changes in this version include:
> o Use Turbine parent pom v13,
> o Minor version updates for deps commons-lang3 to 3.17.0, commons-io to 
> 2.16.1.
> o Use Collections.synchronizedList for serviceList and reentrantLock 
> for lookup method in ServiceContainerImpl o Allow/Export a
> (lightweight) container by default, not only for test, exposing 
> DefaultContainerSetup, ContainerImpl and Container interface.
>
> This version requires Java 17.
>
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because
>
>
> Thanks!
>
> Best regards,
>
> Georg
>
>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@turbine.apache.org
For additional commands, e-mail: dev-h...@turbine.apache.org B 
KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB  [  X  
ܚX KK[XZ[
 ] ][  X  ܚX P\  [ K \X K ܙ B  ܈Y][ۘ[  [X[  K[XZ[
 ] Z[\  [ K \X K ܙ B

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@turbine.apache.org
For additional commands, e-mail: dev-h...@turbine.apache.org

Reply via email to