On Wed, Jun 25, 2008 at 11:07 PM, Luciano Resende <[EMAIL PROTECTED]> wrote:
> This looks very simmilar to an issue we had in SCA 1.2 > (TUSCANY-2202), and it's related to how various web app containers > handle the path differently, and it also works differently if it's > being used as an embedded container. Please take a look at how I fixed > this in 1.2 revision 645253 (sorry if I lost this fix), and a good way > to try is to try is to check in embedded containers, as well as in TC > and WAS. Also, we should cleanup the System.out from there servlet > listner code. > > On Tue, Jun 24, 2008 at 7:40 AM, <[EMAIL PROTECTED]> wrote: > > Author: slaws > > Date: Tue Jun 24 07:40:03 2008 > > New Revision: 671196 > > > > URL: http://svn.apache.org/viewvc?rev=671196&view=rev > > Log: > > TUSCANY-2430 correct the way that the servlet interface is used to > calculate the required feed. This now works on Windows but needs testing on > Linux. > > > > Modified: > > > > tuscany/branches/sca-java-1.3/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java > > > > tuscany/branches/sca-java-1.3/samples/feed-aggregator-webapp/src/main/resources/FeedAggregator.composite > > > > tuscany/branches/sca-java-1.3/samples/feed-aggregator/src/main/resources/FeedAggregator.composite > > > > Modified: > tuscany/branches/sca-java-1.3/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java > > URL: > http://svn.apache.org/viewvc/tuscany/branches/sca-java-1.3/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java?rev=671196&r1=671195&r2=671196&view=diff > > > ============================================================================== > > --- > tuscany/branches/sca-java-1.3/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java > (original) > > +++ > tuscany/branches/sca-java-1.3/modules/binding-atom-abdera/src/main/java/org/apache/tuscany/sca/binding/atom/provider/AtomBindingListenerServlet.java > Tue Jun 24 07:40:03 2008 > > @@ -148,8 +148,15 @@ > > > > // No authentication required for a get request > > > > + System.out.println(request.getRequestURI()); > > + System.out.println(request.getServletPath()); > > + System.out.println(request.getContextPath()); > > + System.out.println(request.getPathInfo()); > > + System.out.println(request.getRequestURL()); > > + > > // Get the request path > > - String path = > URLDecoder.decode(request.getRequestURI().substring(request.getServletPath().length()), > "UTF-8"); > > + String servletPath = request.getContextPath() + > request.getServletPath(); > > + String path = > URLDecoder.decode(request.getRequestURI().substring(servletPath.length()), > "UTF-8"); > > > > logger.fine("get " + request.getRequestURI()); > > > > > > Modified: > tuscany/branches/sca-java-1.3/samples/feed-aggregator-webapp/src/main/resources/FeedAggregator.composite > > URL: > http://svn.apache.org/viewvc/tuscany/branches/sca-java-1.3/samples/feed-aggregator-webapp/src/main/resources/FeedAggregator.composite?rev=671196&r1=671195&r2=671196&view=diff > > > ============================================================================== > > --- > tuscany/branches/sca-java-1.3/samples/feed-aggregator-webapp/src/main/resources/FeedAggregator.composite > (original) > > +++ > tuscany/branches/sca-java-1.3/samples/feed-aggregator-webapp/src/main/resources/FeedAggregator.composite > Tue Jun 24 07:40:03 2008 > > @@ -31,7 +31,7 @@ > > > > <component name="RssAggregator"> > > <implementation.java class="feed.AggregatorImpl"/> > > - <reference name="rssfeed1"> > > + <reference name="rssFeed1"> > > <tuscany:binding.rss uri=" > http://newsrss.bbc.co.uk/rss/newsonline_uk_edition/world/rss.xml"/> > > </reference> > > <reference name="rssFeed2"> > > > > Modified: > tuscany/branches/sca-java-1.3/samples/feed-aggregator/src/main/resources/FeedAggregator.composite > > URL: > http://svn.apache.org/viewvc/tuscany/branches/sca-java-1.3/samples/feed-aggregator/src/main/resources/FeedAggregator.composite?rev=671196&r1=671195&r2=671196&view=diff > > > ============================================================================== > > --- > tuscany/branches/sca-java-1.3/samples/feed-aggregator/src/main/resources/FeedAggregator.composite > (original) > > +++ > tuscany/branches/sca-java-1.3/samples/feed-aggregator/src/main/resources/FeedAggregator.composite > Tue Jun 24 07:40:03 2008 > > @@ -31,7 +31,7 @@ > > > > <component name="RssAggregator"> > > <implementation.java class="feed.AggregatorImpl"/> > > - <reference name="rssfeed1"> > > + <reference name="rssFeed1"> > > <tuscany:binding.rss uri=" > http://newsrss.bbc.co.uk/rss/newsonline_uk_edition/world/rss.xml"/> > > </reference> > > <reference name="rssFeed2"> > > > > > > > > > > -- > Luciano Resende > Apache Tuscany Committer > http://people.apache.org/~lresende <http://people.apache.org/%7Elresende> > http://lresende.blogspot.com/ > Hi Luciano Thanks for bringing the 1.2 change to my attention. It's comforting to see that we both came up with the same solution. I took a look at it and modified the 1.3 change to take account of a slight performance improvement as follows... int servletPathLength = request.getContextPath().length() + request.getServletPath().length(); String path = URLDecoder.decode(requestgetRequestURI().substring(servletPathLength), "UTF-8"); Have you found specific failures with the 1.3 change? Apologies about the system outs. I left them in by mistake. I will remove them Simon
