I have applied your patch for TUSCANY-2458 and TUSCANY-2460 under revision #675836 and #675837. I'd suggest couple things :
1.Looks like you have your gdata binding based on the atom binding, maybe would be a good approach to have it using the atom binding model, and just have this as another atom binding like atom-binding-gdata. Then, if we add the support for RSS, we could still follow the same pattern and have rss-binding-gdata. 2.You are defining your own collection interfaces, could we use the existent collection from data-api ? 3.You have couple test cases under src/test that runs successfully. It would be great if we could automate them using jUnit. 4.Do you have any tests that actually consumes some Google Services ? I'll continue to review your code and provide more feedback. BTW, I have updated the deployGdataToMaven.sh script to deploy the other dependency you require. On Tue, Jul 8, 2008 at 12:52 PM, Luciano Resende <[EMAIL PROTECTED]> wrote: > Thanks Haibo, I'll take a look at them sometime today and see if they > apply better now. > > As for the jars, we have been discussing this on the ML for a > definitive solution, in the meantime, Douglas have sent a shell script > [1] that add two of these files to a maven repo defined in my > people.a.o account, you could provide a jira/patch to add the other > jars that you need. > > [1] > https://svn.apache.org/repos/asf/tuscany/java/sca/modules/binding-gdata-runtime/deployGdataToMaven.sh > > On Tue, Jul 8, 2008 at 12:43 PM, Haibo Zhao <[EMAIL PROTECTED]> wrote: >> Hi Luciano, >> >> It turned out to be some problem with the TortoiseSVN I am using; >> it somehow generates the patch with duplicated files. >> >> I switched to SVN command line and created the patch......double >> checked the patch and found no problem with it. >> >> The remaining issue is that I am not sure how I should put the >> four jar files I am using from GData APIs: >> >> They are: >> >> gdata-client-1.0.jar >> gdata-client-meta-1.0.jar >> gdata-core-1.0.jar >> gdata-media-1.0.jar >> >> I currently put them in the local project classpath, and I guess >> they should be placed the same as other jars being used in Tuscany. >> Luciano, do you have any suggestions? >> >> Please let me know if you have any questions or find any problems >> with the patch, I will fix it and get back to you ASAP. >> >> Thanks, >> Haibo >> > > > > -- > Luciano Resende > Apache Tuscany Committer > http://people.apache.org/~lresende > http://lresende.blogspot.com/ > -- Luciano Resende Apache Tuscany Committer http://people.apache.org/~lresende http://lresende.blogspot.com/
