When testing my fix to TUSCANY-2324, I discovered a problem in
xqueryquotewsclient.composite in the quote-xquery sample.

The lines:

    <reference name="availQuoteProvider" 
promote="QuoteJoinExternalReferencesComponent/availQuoteProvider">
        <interface.java interface="xquery.quote.AvailQuoteProviderService" />
        <binding.ws 
wsdlElement="http://quote.xquery#wsdl.port(AvailQuoteProviderService/AvailQuoteProviderSoapPort)"
 />
    </reference>

are causing a problem because the TUSCANY-2324 fix causes the <interface.java>
definition to be copied down to the underlying promoted reference, and this 
doesn't
work with <implementation.xquery>.

From looking at the test code, it doesn't seem that this <interface.java>
definition is a necessary part of the test, so I changed the above to:

    <reference name="availQuoteProvider" 
promote="QuoteJoinExternalReferencesComponent/availQuoteProvider">
        <!-- removed because it doesn't work with TUSCANY-2324 fix
        <interface.java interface="xquery.quote.AvailQuoteProviderService" />
        -->
        <binding.ws 
wsdlElement="http://quote.xquery#wsdl.port(AvailQuoteProviderService/AvailQuoteProviderSoapPort)"
 />
    </reference>

and this worked OK.

I'm planning to make the above change in my check-in for the builder changes
that include the fix for TUSCANY-2324.  Ideally I'd like to delete the
extraneous line completely, because of the confusion that it may cause
someone trying to understand what this sample does.  Does anyone know of a
reason why I should not do this?

  Simon

Reply via email to