I found the following issues in DefaultUnknownElementProcessor.

- it's an implementation class, in an API package

- it creates a new instance of the processor for each unknown element

- it creates a new DOM document for each unknown element

- it creates a new DocumentBuilderFactory per instance of the processor

- DocumentBuilderFactory.newInstance() doesn't work in OSGi (which is why I got to look at that class), instead it should obtained once from the ServiceDiscovery when the runtime boots and passed around, like we do for the other factories

- minor, the code is difficult to read as formatting is off mixing tabs and spaces

I've removed it from the sca-equinox branch for now as it was breaking it, I'll merge it back from trunk when I see it fixed there.
--
Jean-Sebastien

Reply via email to