On Thu, Sep 18, 2008 at 8:41 PM, Scott Kurz <[EMAIL PROTECTED]> wrote:
> Simon, > > No I didn't open a JIRA for this. If this is bad practice I apologize. I > thought adding a couple lines just to a vtest test would be something no one > would care about, so maybe I erred on the side of not saying anything. > > Scott > > > > On Thu, Sep 18, 2008 at 5:11 AM, Simon Laws <[EMAIL PROTECTED]>wrote: > >> >> >> On Tue, Sep 16, 2008 at 9:52 PM, <[EMAIL PROTECTED]> wrote: >> >>> Author: scottkurz >>> Date: Tue Sep 16 13:52:36 2008 >>> New Revision: 696050 >>> >>> URL: http://svn.apache.org/viewvc?rev=696050&view=rev >>> Log: >>> Account for possibility of binding impl wrappering exc in >>> ServiceRuntimeExc >>> >>> Modified: >>> >>> >>> tuscany/branches/sca-java-1.3.2/vtest/java-api/apis/componentcontext/src/test/java/org/apache/tuscany/sca/vtest/javaapi/apis/componentcontext/ComponentContextTestCase.java >>> >>> Modified: >>> tuscany/branches/sca-java-1.3.2/vtest/java-api/apis/componentcontext/src/test/java/org/apache/tuscany/sca/vtest/javaapi/apis/componentcontext/ComponentContextTestCase.java >>> URL: >>> http://svn.apache.org/viewvc/tuscany/branches/sca-java-1.3.2/vtest/java-api/apis/componentcontext/src/test/java/org/apache/tuscany/sca/vtest/javaapi/apis/componentcontext/ComponentContextTestCase.java?rev=696050&r1=696049&r2=696050&view=diff >>> >>> ============================================================================== >>> --- >>> tuscany/branches/sca-java-1.3.2/vtest/java-api/apis/componentcontext/src/test/java/org/apache/tuscany/sca/vtest/javaapi/apis/componentcontext/ComponentContextTestCase.java >>> (original) >>> +++ >>> tuscany/branches/sca-java-1.3.2/vtest/java-api/apis/componentcontext/src/test/java/org/apache/tuscany/sca/vtest/javaapi/apis/componentcontext/ComponentContextTestCase.java >>> Tue Sep 16 13:52:36 2008 >>> @@ -26,6 +26,8 @@ >>> import org.junit.Ignore; >>> import org.junit.Test; >>> >>> +import org.osoa.sca.ServiceRuntimeException; >>> + >>> /** >>> * This test class tests the ComponentContext interface described in >>> 1.7.1 of >>> * the SCA Java Annotations & APIs Specification 1.0. Relevant sections >>> of 1.4 >>> @@ -164,6 +166,10 @@ >>> a.illegalCast(); >>> } catch (IllegalArgumentException iae) { >>> check = "IllegalCast"; >>> + } catch (ServiceRuntimeException sre) { >>> + if (sre.getCause() instanceof IllegalArgumentException) { >>> + check = "IllegalCast"; >>> + } >>> } >>> Assert.assertEquals("IllegalCast", check); >>> } >>> >>> >>> >> Hi Scott, was there a JIRA number for this one? I'd like to make sure we >> include it in the release notes so that anyone picking up 1.3.2 can refer >> back to it. >> >> Simon >> > > It's just useful when it comes to writing the CHANGES log for the release . Having a JIRA number to refer to seems to me to be more consistent. Simon
