Hi Raymond,
Thanks for fixing the failing test cases.
I like to clarify on the comment that I came across. "In XmlSchema 1.4.x,
the schema collection can only have a single schema instance for a sysid+ns
combination. 1.3.x used to not care and would create multiple schemas with
the same id+ns."
After the fixes you have provided it looks like the 2 inline schema with the
same namespace in databindings-jaxb-top-down itest in
standard-types-service.wsdl file as shown below
<xs:schema targetNamespace="http://jaxb.dev.java.net/array";
version="1.0" xmlns:xs="http://www.w3.org/2001/XMLSchema";>
</xs:schema>
<xs:schema targetNamespace="http://jaxb.dev.java.net/array";
version="1.0" xmlns:xs="http://www.w3.org/2001/XMLSchema";>
</xs:schema>
does not throw exception anymore. Does this mean that XmlSchema 1.4.x
supports this kind of schema declaration? In the previous version XmlSchema
1.3.x the first inline schema is ignored and the latest is always choosen as
a valid one. Not sure how 1.4.x handles this?
Also as part of TUSCANY-2606 fixes, I have added a few lines of code as
shown below in the XSDModelResolver.java at linenumber 170
for (XmlSchema d : schemaCollection.getXmlSchemas()) {
if
(d.getTargetNamespace().equals(definition.getNamespace())) {
if
(d.getSourceURI().equals(definition.getLocation().toString()))
return;
}
}
to avoid the resolver to add the same schema more than once in the schema
collections. I hope this fix is good enough.
On Fri, Sep 19, 2008 at 2:27 AM, Raymond Feng <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I'll try to commit the patches. For the failing test cases, I'll use
> calss-level @Ignore to skip them.
>
> Thanks,
> Raymond
>
> From: Ramkumar R
> Sent: Thursday, September 18, 2008 12:09 PM
> To: [email protected]
> Subject: Re: [DISCUSS] Migration to Axis2 1.4.1
>
>
> Raymond Feng wrote:
>
> +1 for the corresponding dependency upgrade.
>
> I also suggest that you check in the changes as soon as most of the test
> cases are passing. We can add @Ignore("TUSCANY-xxxx") to failing test cases
> with JIRAs. This way, other people can help too.
>
>
>
>
>
> Hi Raymond,
> Thanks for the suggestion. The patches are now available for TUSCANY-2606.
>
> I have commented out the complete junit test for the below mentioned
> modules as @Ignore did not work in this scenario.
> samples - helloworld-ws-service-secure
> itest - databindings-jaxb-top-down
>
> and few test cases in binding-ws-axis2 module.
>
> --
> Thanks & Regards,
> Ramkumar Ramalingam
>
--
Thanks & Regards,
Ramkumar Ramalingam
