Simon Nash wrote:
[EMAIL PROTECTED] wrote:
Author: jsdelfino
Date: Mon Oct 6 01:32:38 2008
New Revision: 702000
URL: http://svn.apache.org/viewvc?rev=702000&view=rev
Log:
Work in progress. Started to clean up cross-bundle dependencies on
ContributionService implementation class, the various CompositeBuilder
implementation classes and the ContributionDependencyBuilder
implementation class. Added extension points for ContributionBuilders
and CompositeBuilders to have them discovered and loaded by the
Equinox ServiceDiscovery like other extension points. Moved injection
of monitors and SCA definitions to the build methods instead of the
constructors to remove references to these implementation
constructors. Simplified NodeImpl a bit to remove references to other
runtime implementation classes.
> (cut)
Modified:
tuscany/branches/sca-equinox/itest/builder/src/test/java/org/apache/tuscany/sca/itest/builder/CompositeBuilderNonWiringImpl.java
URL:
http://svn.apache.org/viewvc/tuscany/branches/sca-equinox/itest/builder/src/test/java/org/apache/tuscany/sca/itest/builder/CompositeBuilderNonWiringImpl.java?rev=702000&r1=701999&r2=702000&view=diff
==============================================================================
---
tuscany/branches/sca-equinox/itest/builder/src/test/java/org/apache/tuscany/sca/itest/builder/CompositeBuilderNonWiringImpl.java
(original)
+++
tuscany/branches/sca-equinox/itest/builder/src/test/java/org/apache/tuscany/sca/itest/builder/CompositeBuilderNonWiringImpl.java
Mon Oct 6 01:32:38 2008
@@ -49,16 +49,12 @@
public class CompositeBuilderNonWiringImpl implements CompositeBuilder {
private static final Logger logger =
Logger.getLogger(CompositeBuilderNonWiringImpl.class.getName());
private CompositeBuilder compositeIncludeBuilder;
- //private CompositeBuilder componentReferenceWireBuilder;
- //private CompositeBuilder componentReferencePromotionWireBuilder;
- //private CompositeBuilder compositeReferenceWireBuilder;
private CompositeBuilder compositeCloneBuilder;
private CompositeBuilder componentConfigurationBuilder;
private CompositeBuilder compositeServiceConfigurationBuilder;
private CompositeBuilder compositeReferenceConfigurationBuilder;
private CompositeBuilder compositeBindingURIBuilder;
private CompositeBuilder componentServicePromotionBuilder;
- //private CompositeBuilder compositeServicePromotionBuilder;
private CompositeBuilder compositePromotionBuilder;
private CompositeBuilder compositePolicyBuilder;
private CompositeBuilder componentServiceBindingBuilder;
>
The commented out lines in the above extract, and the equivalent
commented out
lines in the executable code of this class, are there for a reason and
should
be reinstated. They indidate where the differences are between the real
CompositeBuilderImpl and this special test version.
Ah, thanks for telling me. I'll add the commented lines, with an
additional comment indicating why they are there.
--
Jean-Sebastien
