The fix introduced some problems for the samples and itests which are not OSGi 
bundles if we run "mvn -Peclipse" from the "sca" folder. 

What we had before for the "eclipse" profile was as follows:

1) For the "modules", the maven-eclipse-plugin was skipped and our 
maven-bundle-plugin created the .project/.classpath files to be PDE friendly.
2) For other things such as "samples" and "itest", the maven-eclipse-plugin was 
used to produce the normal .project/.classpath files.  
3) mvn -Peclipse and mvn -Peclipse eclipse:eclipse were the same

Anyway, I enhanced the tuscany-maven-bundle-plugin to work with non-OSGi 
projects. For the latest trunk, we can run mvn -Peclipse for both OSGi and JSE 
projects.

BTW, "mvn eclipse:eclipse" should be discouraged as it will generate Eclipse 
projects which do not leverage the PDE validation of the OSGi constraints. 

For the name of the profile, we can rename it to "pde" if it helps.

Thanks,
Raymond


From: ant elder 
Sent: Monday, February 09, 2009 6:48 AM
To: [email protected] 
Subject: Re: svn commit: r739245 - /tuscany/java/sca/modules/core/pom.xml


I've now fixed this in r742527. Run "mvn eclipse:eclipse" to use the regular 
Eclipse Java environment or as before use "mvn -Peclipse" to use the Eclipse 
PDE environment. Might be worth renaming the eclipse profile to be eclipsepde 
to make it a bit more descriptive.

   ...ant    


On Wed, Feb 4, 2009 at 1:12 PM, ant elder <[email protected]> wrote:

  I've created TUSCANY-2819 to track doing this.

     ...ant 



  On Sat, Jan 31, 2009 at 9:36 AM, ant elder <[email protected]> wrote:

    Yes the problem with the notice files is fixed now so it would be really 
good to have "mvn eclipse:eclipse" work as thats the standard way to do this. 
So what are the plugins that don't get activated when using -Peclipse so we can 
see if there's some other way we can fix that? (I can't help much investigate 
this just now as I've still not got it to work properly with -Peclipse yet)

    What I think we should be trying to do is make tuscany work in the most 
standard way as possible so people can get started with minimal education. I 
can checkout lots of projects which use maven and without any reading know i 
can do things like "mvn" or "mvn clean install" or "mvn eclipse:eclipse" from 
the top of the src and have it build and setup in an ide, and that standard 
consistent behaviour makes it so much easier to start working.

       ...ant 



    On Fri, Jan 30, 2009 at 6:07 PM, Raymond Feng <[email protected]> wrote:

      Hi,

      We have eclipse:eclipse as the default goal for "eclipse" profile 
(-Peclipse). The "eclipse" profile gives us a bit control, for example, some 
plugins won't be activated under that profile as "eclipse:eclipse" will trigger 
all the plugins using "generate-resources" phase.

      I also remember that we use "eclipse" profile to work around an issue 
related to the the NOTICE/LICENSE file in the root of the project. But it seems 
that the latest Eclipse plugin can handle the source folder overlapping and 
exclusion now.

      Thanks,
      Raymond


      From: ant elder 
      Sent: Friday, January 30, 2009 9:55 AM
      To: [email protected] 
      Subject: Re: svn commit: r739245 - /tuscany/java/sca/modules/core/pom.xml
      [snip]


        Hi Ant

        You don't need eclipse:eclipse anymore. Give mvn -Peclipse a try and 
see if that helps.



      Is there a reason we have to do this with a -Peclipse (sorry if its 
obvious I've not looked at all how this is setup), it would be nice if we could 
keep the "mvn eclipse:eclipse" standard instead of using our own special way.

         ...ant
       





Reply via email to