ant elder wrote:
Currently the node-impl module has dependencies on implementation-node
and the workspace modules, I think its worth exploring if thats
necessary. In r772526 i've created a new node-impl2 module thats a
copy of node-impl but with no dependencies on implementation-node or
the workspace modules. It does include 4 classes copied from
workspace-impl and they're still in the o.a.t.s.workspace package to
make that obvious. Comparing the two node-impl modules i think this
makes node-impl2 significantly cleaner and shows that having those
contribution classes in workspace-impl may not be the correct place
and they'd be better in one of the contribution* modules.
Any comments?
...ant
Ant,
I too am puzzled by the presence of the Contribution related classes in the
workspace-impl module.
I could not make any sense of why they were there rather than in the
Contribution module.
Can anyone offer an explanation of why the Contribution code is organized in
this way?
If there is no good reason for the current split then I'd argue for moving the code into the
contribution module.
Yours, Mike.
