On Fri, May 29, 2009 at 4:15 PM, Simon Laws <[email protected]> wrote: > On Thu, May 28, 2009 at 7:51 AM, ant elder <[email protected]> wrote: >> On Wed, May 27, 2009 at 5:34 PM, Raymond Feng <[email protected]> wrote: >>> The following commits got my attentions: >>> >>> http://svn.apache.org/viewvc?rev=779058&view=rev >>> http://svn.apache.org/viewvc?rev=779059&view=rev >>> >>> I think the consensus is to keep the workspace/workspace-impl to deal with a >>> collection of contributions. As we rebuild the domain story, there modules >>> are still needed. >>> >>> Thanks, >>> Raymond >> >> Nothing in trunk is currently using them so it seems better to try to >> keep the 2.x code lean and clean and to not have unused code/modules >> kept in "just in case". Thats one of the purposes of 2.x isn't it - to >> enable cleaning up all the code thats built up in 1.x over the years. >> They're just moved to contrib so not gone for ever and can easily be >> copied back whenever they're needed. >> >> I do think it would be good to reevaluate what the requirements are >> before bringing this back in though, the workspace has always seemed a >> bit odd to me. >> >> ...ant >> > > Where's the cross contribution dependency stuff gone now then? > > Simon >
Is that the buildDependencies and addContributionDependencies methods in NodeFactoryImpl in the node-impl module? ...ant
