On Mon, Jun 1, 2009 at 4:43 PM, Raymond Feng <[email protected]> wrote:
> Comments inline.
>
> --------------------------------------------------
> From: "Simon Laws" <[email protected]>
> Sent: Monday, June 01, 2009 5:44 AM
> To: <[email protected]>; <[email protected]>
> Subject: Re: Discovery-based SCA Domain for OSGi RFC 119
>
> [[snip]]
>
>>
>> What I would like to see is a simple registry style interface for
>> handling endpoint information, e.g.
>>
>> public interface EndpointRegistry  {
>>   void addEndpoint(Endpoint2 endpoint);
>>   void removeEndpoint(Endpoint2 endpoint);
>>   void addEndpointReference(EndpointReference2 endpointReference);
>>   void removeEndpointReference(EndpointReference2 endpointReference);
>>   List<Endpoint2> findEndpoint(EndpointReference2 endpointReference);
>>   List<EndpointReference2> findEndpointReference(Endpoint2 endpoint);
>> }
>>
>> Two reasons, firstly we need to be able to ask the "domain" questions
>> about endpoints. Secondly I'm interested at the moment as we need to
>> understand how to ask endpoint resolution questions in order to finish
>> off the endpoint code. For example, one of the changes that is still
>> outstanding is support for serialization required by callable
>> references, this could help here also.
>>
>
> Yes, this is what I have in mind too. A few comments.
>
> 1) Do we need to register the endpoint references? For callbacks, we can
> just publish the endpoint for the callback.
> 2) We may need to have a method to return all published endpoints.
> 3) The key of the endpoints is probably the structural URI of the service
> binding.
>
>> The 1.x domain manager provides a whole raft of "interfaces" already.
>>
>> put/get contribution
>> put/get node configuration
>> put/get deployed composite (defines composite/node association)
>>     get composite configuration for individual node
>>
>> There are other things as well, e.g. there are file handling
>> interfaces, but not sure what it is for.
>>
>> In the grand scheme of things we still need these but in many of our
>> scenarios I think we are expecting these interfaces to be called
>> automatically rather than manually though a web gui.
>
> +1.
>>
>> Simon
>
>

In r780938 i've committed an this EndpointRegistry interface, and an
impl of the interface, not sure how long we'd keep that impl for as-is
but it gives something simple to get going with for now. I did add
getters as it helps with debugging for now, and it does still include
the EndpointReferences while we decide if they're really needed here
or not.

   ...ant

Reply via email to