I've been playing around with the template and bulk formatting and haven't yet found any settings which work very well, with the template we have in SVN and any changes i try to to that the reformatted code looks worse than what was there before. The "never join lines" option doesn't seem to be enough and lines are wrapped and/or indented badly. So don't think we should do bulk formatting until we can find a template that doesn't mess up the code.
...ant On Mon, Jul 6, 2009 at 10:42 PM, Luciano Resende<[email protected]> wrote: > Raymond > > Just to make sure we keep up with this formatting, are you using > exactly the same templates available under /etc ? If not, could you > please update it. > > On Mon, Jul 6, 2009 at 1:15 PM, Raymond Feng<[email protected]> wrote: >> I'm fine with the "never join lines" option. >> >> Thanks, >> Raymond >> >> -------------------------------------------------- >> From: "ant elder" <[email protected]> >> Sent: Monday, July 06, 2009 12:12 PM >> To: <[email protected]> >> Subject: Re: svn commit: r791550 [1/5] - in >> /tuscany/java/sca/modules/assembly/src: >> main/java/org/apache/tuscany/sca/assembly/ >> main/java/org/apache/tuscany/sca/assembly/builder/ >> main/java/org/apache/tuscany/sca/assembly/builder/impl/ >> main/java/org/apache/tusc >> >>> On Mon, Jul 6, 2009 at 6:39 PM, <[email protected]> wrote: >>>> >>>> Author: rfeng >>>> Date: Mon Jul 6 17:39:44 2009 >>>> New Revision: 791550 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=791550&view=rev >>>> Log: >>>> Organize imports and reformat the code >>>> >>>> Modified: >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/AbstractContract.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/AssemblyFactory.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Base.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Binding.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/BindingRRB.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Component.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/ComponentProperty.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/ComponentReference.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/ComponentService.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/ComponentType.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Composite.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/CompositeReference.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/CompositeService.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Contract.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/DistributedSCABinding.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Endpoint.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/EndpointReference.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Extensible.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/OperationSelector.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/OptimizableBinding.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Property.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Reference.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/SCABindingFactory.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Service.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/Wire.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/WireFormat.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/AutomaticBinding.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/BindingBuilder.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/BindingBuilderExtension.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/CompositeBuilder.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/CompositeBuilderExtensionPoint.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/CompositeBuilderTmp.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/DefaultCompositeBuilderExtensionPoint.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/DomainBuilder.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/EndpointReferenceBuilder.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/BaseBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ComponentConfigurationBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ComponentReferenceBindingBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ComponentReferenceEndpointReferenceBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ComponentReferencePromotionBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ComponentReferencePromotionWireBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ComponentReferenceWireBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ComponentServiceBindingBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ComponentServiceEndpointBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ComponentServicePromotionBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeBindingConfigurationBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeBindingURIBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeCloneBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeIncludeBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositePromotionBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeReferenceConfigurationBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeReferenceWireBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeServiceBindingBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeServiceConfigurationBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeServicePromotionBuilderImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/PolicyConfigurationException.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/PolicyConfigurationUtil.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/PropertyConfigurationUtil.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ReferenceConfigurationUtil.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ServiceConfigurationUtil.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/AbstractPropertyImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/AbstractReferenceImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/AbstractServiceImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/AssemblyFactoryImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/BaseImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/CallbackImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ComponentImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ComponentPropertyImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ComponentReferenceImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ComponentServiceImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ComponentTypeImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/CompositeImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/CompositeReferenceImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/CompositeServiceImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ConstrainingTypeImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ContractImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/DistributedSCABindingImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/EndpointImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/EndpointReferenceImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ExtensibleImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ExtensionImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/PropertyImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ReferenceImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/SCABindingFactoryImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/SCABindingImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/ServiceImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/impl/WireImpl.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/test/java/org/apache/tuscany/sca/assembly/AssemblyFactoryTestCase.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/test/java/org/apache/tuscany/sca/assembly/TestInterfaceContract.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/test/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeBuilderTestCase.java >>>> >>>> >>>> tuscany/java/sca/modules/assembly/src/test/java/org/apache/tuscany/sca/assembly/builder/impl/PrintUtilTestCase.java >>>> >>> >>> I'm +1 on reformatting like this but one thing i've never liked about >>> the eclipse formatter is the line wrapping as it often makes a hash of >>> existing formatting, so how about we use the the new feature in >>> Eclipse 3.5 where the formatter has an option to say "never join >>> lines", see >>> http://update.eclipse.org/downloads/drops/R-3.5-200906111540/eclipse-news-all.html#JDT? >>> Could we use that for bulk formatting changes like this? >>> >>> ...ant >> >> > > > > -- > Luciano Resende > Apache Tuscany, Apache PhotArk > http://people.apache.org/~lresende > http://lresende.blogspot.com/ >
