I made one more fix to stop all nodes and release the extension points and extensions when the OSGi node bundle is stopped.

http://svn.apache.org/viewvc?rev=799487&view=rev

Now we still see the messages like:

2009-07-30 22:36:30.671::INFO:  Shutdown hook executing
2009-07-30 22:36:30.671::INFO:  Shutdown hook complete
2009-07-30 22:36:30.671::INFO:  Shutdown hook executing
2009-07-30 22:36:30.671::INFO:  Shutdown hook complete
2009-07-30 22:36:30.671::INFO:  Shutdown hook executing
2009-07-30 22:36:30.671::INFO:  Shutdown hook executing
2009-07-30 22:36:30.671::INFO:  Shutdown hook complete
2009-07-30 22:36:30.671::INFO:  Shutdown hook complete

But the Jetty shutdown hook doesn't contain any server instances. So there is just one instance of the hook per JVM and it should be fine.

Thanks,
Raymond
--------------------------------------------------
From: "Raymond Feng" <[email protected]>
Sent: Thursday, July 30, 2009 12:55 PM
To: <[email protected]>
Subject: Re: otest permgen failures

Hi,

I checked in a fix under r799429 to make sure:

1) The EndpointReferences will be removed from the EndpointRegistry when the component is stopped 2) The local Endpoints and EndpointReferences will be removed upon the stop of the EndpointRegistry (end of NodeFactory/Node)

Thanks,
Raymond
--------------------------------------------------
From: "Simon Laws" <[email protected]>
Sent: Thursday, July 30, 2009 6:23 AM
To: <[email protected]>
Subject: Re: otest permgen failures

Thanks Kevan

That's very useful. It's seems we need to at least look a little more
closely at the EndpointRegsitry which, in it's default guise that we
use for testing, has static collections of Endpoints and
EndpointReferences.  In theory everything that is added during runtime
should be removed at the end but obviously there is scope for leaks
with this kind of thing.

When I run the tests now I'm seeing heap space rather than perm get
problems and it get's very slow toward the end of the run. Haven't
applied Ant's Jetty fix yet.

Simon

Reply via email to