On Tue, Aug 11, 2009 at 6:05 PM, Raymond Feng<[email protected]> wrote: > I have a fix for the problem now. I'll check it in soon. > > 1) We have a bug in ValidatingXMLStreamReader.next() which doesn't trigger > the startDocument(). As a result, all the elements are skipped from > validation. CompositeDocumentProcessor uses nextTag() while > DefinitionsDocumentProcessor uses next(). That's why we don't see problems > with composite files.
Thanks Raymond. Would have taken me a while to work that out! > > 2) The DefaultSchemaValidationExtensionPoint is DISABLED by default. Should > we turn it on for unit tests? I understand we control the flag at NodeImpl > level too. > What are the current rules/mechanisms for enabling/disabling validation? If we could have a single flag at the node level for enabling/disabling all validation then I think that would be more appropriate than addressing composite/contribution/definitions/component type independently. Happy to help here if we can decide what to do. Simon
