PERF: handleCallback is not optimized
-------------------------------------
Key: TUSCANY-3348
URL: https://issues.apache.org/jira/browse/TUSCANY-3348
Project: Tuscany
Issue Type: Improvement
Components: Java SCA Core Runtime
Environment: All
Reporter: Hasan Muhammad
Fix For: Java-SCA-1.5.2, Java-SCA-2.0
The following change in JDKInvocationHandler.handleCallback() improves
performance when callback is not defined.
From:
-----------------------------------
private void handleCallback(Message msg, RuntimeWire wire, Object
currentConversationID)
throws TargetResolutionException {
ReferenceParameters parameters = msg.getFrom().getReferenceParameters();
parameters.setCallbackID(getCallbackID());
if (msg.getFrom() == null || msg.getFrom().getCallbackEndpoint() ==
null) {
return;
}
parameters.setCallbackReference(msg.getFrom().getCallbackEndpoint());
------------------------------------
To:
------------------------------------
private void handleCallback(Message msg, RuntimeWire wire, Object
currentConversationID)
throws TargetResolutionException {
if (msg.getFrom() == null || msg.getFrom().getCallbackEndpoint() ==
null) {
return;
}
ReferenceParameters parameters = msg.getFrom().getReferenceParameters();
parameters.setCallbackID(getCallbackID());
parameters.setCallbackReference(msg.getFrom().getCallbackEndpoint());
-------------------------------------
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
