The rest of the release is looking pretty good. I've been though most
of the samples and build a couple of the sample webapps from the maven
repo. Some more comments....
Samples README
samples list doesn't match samples- In M5 I'd like to remove the
sample list (as we struggle to
keep it up to date) and make the sample directory names more meaningful
ant run-classes target documented but we don't suport it
should add launcher instructions
samples/dosgi-calculator & dosgi-calculator-operations
version of osgi referenced in README is out of date. Run commands as
stated don't work
samples/webapps
no instructions/README detailing how to build/use the webapps
samples/webapps/helloworld
doesn't apparently do anything apart from load the composite
samples/webapps/helloworld-servlet
seems to work but reports the following
INFO: ContextPath: /helloworld-servlet
HelloworldServlet reference injection failed, using ComponentContext
Based on the header issues I'm -1. Would be good for us to fix at
least the dosgi README issue also.
Regards
Simon
