*Hi Simon,*

Comments inline...

Not sure if this is important or not. In the implementation invoker we
> need to set TCCL to the contribution classloader that loaded the
> implementation class we are about to call. So how to get the
> contribution and it's classloader for the class we are about to call.
> The easy way is to get the classloader from the class and set that of
> course. I don't know if no changes have been made to make this work or
> that some changes have been made but that something was missed out.
>
>
The issue seems to be resolved and the testcase passes, by setting the TCCL
to the
classloader that loaded the implementation class we are about to call.

But this approach raises few questions in my mind as shown below...

1. In 1.x code base, we have been using the ContributionClassLoaderProvider
to set the
classloader for the contribution, but in 2.x not sure about the reason as
why decided to
get away with ContributionClassLoaderProvider.

2. May be, I am not understanding the big picture as why the specs is so
keen in
doing so. What would be the disadvantage if we don't set the TCCL to the
contribution classloader.


-- 
Thanks & Regards,
Ramkumar Ramalingam

Reply via email to