A few of PMC members including me are out for vacation. Would it be possible
that we hold off some of the changes? See my brief comments inline.
Thanks,
Raymond
--------------------------------------------------
From: "ant elder" <[email protected]>
Sent: Tuesday, December 15, 2009 3:31 AM
To: <[email protected]>
Subject: Re: [2.x] node configuration attributes
On Wed, Dec 9, 2009 at 2:41 PM, ant elder <[email protected]> wrote:
Some to remove:
- all the ones using classloaders
- the Client Interface and just add the getService method to Node
- the destroy method
- the getInstance(String domainURI) as there's the createNode that
includes the URI
+1. Do you plan to have a Helper that can be used to populate
NodeConfiguration from the resource and classloader?
Another method to consider for removal is the Node start() method. I
don't see why is thats needed now as after a node is created you can
do nothing except start or stop it so it might as well just be created
in the started state. If for some reason the was a need to pass around
an unstarted Node you can just pass around a NodeConfiguration
instead.
I prefer to keep the start() method for a few reasons:
1) symmetric with stop(): users of the API will remember to call stop() if
they call start().
2) consistent with the other SPIs that involve the lifecycle management,
such as LifeCycleListener
3) the start/stop can be potentially exposed to management layer
Can we hold it off?
...ant
