[ 
https://issues.apache.org/jira/browse/TUSCANY-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Luciano Resende resolved TUSCANY-3494.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: Java-DAS-Next
         Assignee: Luciano Resende

Patch applied. Thanks Florian Pinel.

> Issue with DAS.createCommand(String sql)
> ----------------------------------------
>
>                 Key: TUSCANY-3494
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-3494
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java DAS RDB
>    Affects Versions: Java-DAS-beta1
>            Reporter: Florian Pinel
>            Assignee: Luciano Resende
>             Fix For: Java-DAS-Next
>
>         Attachments: TUSCANY-3494.patch
>
>
> The implementation of DAS.createCommand(String sql) assumes that all SELECT 
> statements start with the letter S, which is not true.
> For example, a select statement in DB2 can start with a Common Table 
> Expression:
> WITH identifier AS (select stmt) select stmt
> There may be other database-dependent examples for other kinds of commands.
> I suggest that we add the following method to the DAS interface:
>     /**
>      * Creates a Command of the specified kind based on the provided SQL 
> statement
>      * 
>      * @param sql
>      *            The SQL statement
>      * @param sql
>      *            The Command kind (select, insert, update, delete or 
> procedure), case-insensitive
>      * @return returns a Command instance
>      */
>     Command createCommand(String sql, String kind);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to