On Tue, May 11, 2010 at 7:02 AM, ant elder <[email protected]> wrote: > On Thu, May 6, 2010 at 12:42 PM, Simon Laws <[email protected]> wrote: >> On Thu, May 6, 2010 at 12:05 PM, ant elder <[email protected]> wrote: >>> On Thu, May 6, 2010 at 11:47 AM, Simon Laws <[email protected]> >>> wrote: >>>> On Thu, May 6, 2010 at 11:35 AM, ant elder <[email protected]> wrote: >>>>> What if anything do we need to do to tidy up the samples for the >>>>> upcoming release? Consistency across similar types of samples seems >>>>> like it could be improved for example so they're run in similar ways. >>>>> I've been slowly going through making the standalone contribution >>>>> samples runnable using "mvn tuscany:run" and the webapp samples with >>>>> "mvn jetty:run", what else would people like to see? >>>>> >>>>> ...ant >>>>> >>>> >>>> Well personally I'd rename some of them so that the technology that >>>> they're trying to demonstrate comes first (and I'm happy to do that if >>>> no-one objects). Some of them are general and their names are fine. >>>> I'd also create a sub directory to hold samples with multiple parts, >>>> e.g. a reference and a service. It just looks a jumble at the moment. >>>> >>> >>> Could you give some examples of what you'd change? Here's the list of >>> the top level samples: >>> >>> binding-ws-calculator >>> calculator >>> calculator-equinox >>> calculator-osgi >>> calculator-rmi-reference >>> calculator-rmi-service >>> dosgi-calculator >>> dosgi-calculator-operations >>> dosgi-dynamic-calculator >>> dosgi-dynamic-calculator-operations >>> helloworld >>> helloworld-bpel >>> helloworld-scaclient >>> helloworld-spring >>> helloworld-ws-sdo >>> implementation-java-calculator >>> store >>> store-webapp >>> >>> ...ant >>> >> >> I would change this list to be... >> >> >> binding-ws-calculator >> binding-ws-sdo-helloworld >> binding.sca-calculator >> binding-rmi-calculator >> binding-rmi-calculator-reference >> binding-rmi-calculator-service >> launcher-equinox-calculator >> osgi-bundle-calculator >> dosgi-calculator >> dosgi-calculator >> dosgi-calculator-operations >> dosgi-dynamic-calculator >> dosgi-dynamic-calculator >> dosgi-dynamic-calculator-operations >> implementation-java-calculator >> implementation-java-helloworld >> implementation-bpel-helloworld >> implementation-spring-helloworld >> scaclient-helloworld >> store >> store-webapp >> > > The thread went on and no one has replied to that so here are some comments. > > I like that some of them have been moved to be in sub-directories. The > problem i have with it is that it not obvious where to start. When I > first look at a new project one of the things i do is without reading > much doc or anything go to samples and run helloworld and then look at > the source of helloworld to see what it did. So i like there to be a > helloworld and to have that sample concise as possible and not include > anything at all which isn't necessary to do that minimum thing. > > What about keeping at least the minimal helloworld samples at the top > and have subfolders named after the each extension which contain > multiple samples for that: > > helloworld > helloworld-scaclient > binding-ws > helloworld > sdo > mtom > basic-auth > ws-security > > etc > > ...ant >
That's a good idea. It's already the case that some samples aren't extension specific so I think have a non-extension specific helloworld fits in well Simon -- Apache Tuscany committer: tuscany.apache.org Co-author of a book about Tuscany and SCA: tuscanyinaction.com
