On Tue, Jul 6, 2010 at 1:49 PM, ant elder <[email protected]> wrote: > On Mon, Jul 5, 2010 at 4:00 PM, Simon Laws <[email protected]> wrote: > > >> I haven't really got my mind around how this is set up to work so I'll >> comment when I've looked at the code. >> > > To explain that bit: > > In the core-spi module there is a class org.apache.tuscany.sca.runtime > which has three methods: > > String getVersion() > String getRevsion() > String getBuildTime() > > The version is just got from the version in the pom.xml but the other > two require the buildnumber-maven-plugin to populate the values. The > buildnumber-maven-plugin uses svn to get the revision so svn must be > available in the build environment, if svn isn't available the plugin > fails and kills the build and there doesn't seem to be any way to tell > it to ignore the error and let the build carry on. > > ...ant >
Thanks Ant So version will be something like 2.0-M6-SNAPSHOT or whatever build time with be the date/time the build was run (why is buildnumber-maven-plugin require for that?) review is the latest revision from svn from the codebase that this build built code for? I'm happy to install command line svn in my environment to make this work. A couple of thoughts... When we do a build where this is important, i.e. a distro candidate or proper distribution we will have committed all the files to a tag so would it be possible to use an svn keyword substitution to get the revision instead of relying on plugins running svn? The person doing the build must have checked the tag out in the first place. I guess you could use this argument to say that they must have svn so why not install it on the command line. I note that the plugin docs says... "Optionally, you can configure this mojo to produce a revision based on a timestamp, or on a sequence, without requiring any interaction with an SCM system. Note that currently, the only supported SCM is subversion." This is not as useful as the actual svn code revision we are building. Depends what this revision number is being used for. Simon -- Apache Tuscany committer: tuscany.apache.org Co-author of a book about Tuscany and SCA: tuscanyinaction.com
