On Fri, Dec 10, 2010 at 1:12 PM, Mike Edwards <[email protected]> wrote: >> >> I've added a new module, binding-jms-runtime-activemq, which has a new >> ActiveMQ specific JMSResourceFactory impl that overrides the JMS >> binding default one when both modules are used. Would you use that for >> adding the ActiveMQ specific code? >> >> ...ant >> > Ant, > > That misses the point somewhat. My goal here is to enable JMS to run when > using OSGi. So an "ActiveMQ" module does not seem appropriate to me. The > fact that the initial version of OSGi enabled code uses ActiveMQ when > running under OSGi is simply a first step - I don't see why the OSGi code > should not use other JMS providers (assuming they run under OSGi too) > > > Yours, Mike. > >
Ok, would it help to rename the module to binding-jms-runtime-osgi? The changes you've just done have put a hard dependency on ActiveMQ into the JMS binding. Thats not right, and if its really necessary then it needs to be in a separate module just has been done with numerous other modules in Tuscany. ...ant
