On Fri, Jun 17, 2011 at 10:38 AM, Simon Laws <simonsl...@googlemail.com> wrote: > On Fri, Jun 17, 2011 at 6:19 PM, Brent Daniel <brenthdan...@gmail.com> wrote: >> The applies to processing actually does end up working on >> endpoints/endpoint references. It has to operate against the composite >> model since it is XPath based, but when we find policies that need to >> be removed from a service, reference, etc, we remove them from the >> corresponding endpoint or endpoint reference. >> >> There is currently a bug here that surfaces when there are multiple >> endpoints or endpoint references under a service/reference. It's only >> removing the policies from one of the endpoints in this case. I'm >> going to commit a fix for this shortly. >> >> Brent >> >> On Thu, Jun 16, 2011 at 9:26 AM, Simon Laws <simonsl...@googlemail.com> >> wrote: >>> On Thu, Jun 16, 2011 at 5:25 PM, Simon Laws <simonsl...@googlemail.com> >>> wrote: >>>> On Thu, Jun 16, 2011 at 3:55 PM, Brent Daniel <brenthdan...@gmail.com> >>>> wrote: >>>>> Simon, >>>>> >>>>> I've been operating with basically the same set of changes locally and >>>>> things do seem to work fine. >>>>> >>>>> From a design perspective, the unshared model seems like a better >>>>> alternative to me. I'm sure there are performance gains from not >>>>> having to do annotation processing, etc, multiple times, but these >>>>> could probably be achieved with caching elsewhere. >>>>> >>>>> Brent >>>>> >>>> >>>> Ok, Brent. Lets go with it for the time being and see how hangs >>>> together. If you have improvements in your changes over what I added >>>> feel free to go in and fix it up. >>>> >>>> Simon >>>> >>>> -- >>>> Apache Tuscany committer: tuscany.apache.org >>>> Co-author of a book about Tuscany and SCA: tuscanyinaction.com >>>> >>> >>> And I forgot to add that I'm still seeing some residual issues in the >>> way that appliesTo is processed. I think because the applies to >>> processing is based on reference and services where it should really >>> be based on endpints and endpoint references. >>> >>> Simon >>> >>> -- >>> Apache Tuscany committer: tuscany.apache.org >>> Co-author of a book about Tuscany and SCA: tuscanyinaction.com >>> >> > The other thing that is wrong though is that the set of policies it;s > looking at is from the service/reference/binding and not from the > ep/epr where the correct set of policies have been aggregated. > > Simon > > > -- > Apache Tuscany committer: tuscany.apache.org > Co-author of a book about Tuscany and SCA: tuscanyinaction.com >
Simon, Maybe I'm not understanding you, but I think this is working as it should. We are forced to use a two step process, but the policies do get removed from the EPs/EPRs. On the EP side, we loop through the list of component services and see if we need to remove any policy sets. If we do, we also remove the same policy sets from the endpoints for the service (since the endpoints will have inherited the policy sets earlier in the build process.) I think we're kind of stuck with this as it is -- the appliesTo processing can not directly apply to the EP/EPR because it is XPath based and needs to work against the actual composite model. We also can't move it to occur prior to inheritance because it is legal to specify a policy set on an element where it does not apply and have it be inherited by an element where it does apply. Brent
