On Mon, Aug 8, 2011 at 2:08 PM, Simon Laws <simonsl...@googlemail.com> wrote:
> On Fri, Aug 5, 2011 at 10:49 PM, Greg Dritschler
> <greg.dritsch...@gmail.com> wrote:
>> Thanks Mike, this helps a lot.
>> I think the description of nonOverridable needs to explicitly say that it
>> applies to all of the methods described in 4.3.1. It also needs to say that
>> it controls not only how targets are handled between the composite ref and
>> its promoted component ref, but also between the next higher component ref
>> and the composite ref.
>> Simon, I tried adding a test to pushDownEndpointReferences() to look at the
>> nonOverridable setting of the promoted component reference. This fixed my
>> 1..1 tests. I haven't tried other cases yet.
>> for (ComponentReference leafRef : leafComponentReferences){
>> if (!leafRef.isNonOverridable()) {
>> leafRef.getEndpointReferences().clear();
>> }
>> int insertLocation = 0;
>> ...
>> On Fri, Aug 5, 2011 at 11:53 AM, Mike Edwards
>> <mike.edwards.inglen...@gmail.com> wrote:
>>>
>>> Greg,
>>>
>
> OK I re-read what Mike said and I'm back in the "I think the examples
> are correct" camp. Hmmmm.
>
> Greg, I gave the suggested change a go and I see a few issues with a
> full build. Am going through them now so I'll post with details.
>
> Regards
>
> Simon
>
> --
> Apache Tuscany committer: tuscany.apache.org
> Co-author of a book about Tuscany and SCA: tuscanyinaction.com
>
i've created https://issues.apache.org/jira/browse/TUSCANY-3912 to
cover this. From the set of four failures I originally saw on a full
build three are some bogus HTTP endpoint failure. The remaining is
TUSCNAY-5023 which we need to look at.
Simon
--
Apache Tuscany committer: tuscany.apache.org
Co-author of a book about Tuscany and SCA: tuscanyinaction.com
