Hi -

-1 (binding) - willing to discuss with input from other Mentors.

The source release directory consists of a directory of jar files of sources. 
That’s highly unusual. Why is it done this way? Verifying all of these means 
further unpacking. I did this and the files do have license headers.

sources/net/consensys empty directories exist in all of these source jars.

None of the site files have LICENSEs.

I did the LICENSE check with Apache RAT.

java -jar ~/Development/apache-rat-0.12.jar . > rat-out

Creating a .rat-excludes file is always helpful.

Regards,
Dave

> On Apr 30, 2019, at 8:43 AM, Dave Fisher <[email protected]> wrote:
> 
> Hi Antoine,
> 
> The KEYS file needs to be added to 
> https://dist.apache.org/repos/dist/release/incubator/tuweni/.
> 
> It looks like you have the correct files and the signatures and hash are 
> correct.
> 
> I have not done a full evaluation.
> 
> Regards,
> Dave
> 
>> On Apr 30, 2019, at 8:01 AM, Antoine Toulme <[email protected]> wrote:
>> 
>> Dave,
>> 
>> Did you have a chance to look at the new artifacts?
>> 
>>> On Apr 26, 2019, at 20:30, Dave Fisher <[email protected]> wrote:
>>> 
>>> I’m not seeing any signatures (asc) nor any checksum (sha512).
>>> 
>>> Did you create a KEYS file?
>>> 
>>> -1 until these are provided.
>>> 
>>> Out of pocket until Monday. I can provide details then.
>>> 
>>> Regards,
>>> Dave
>>> 
>>> Sent from my iPhone
>>> 
>>>> On Apr 26, 2019, at 4:35 PM, Antoine Toulme <[email protected]> wrote:
>>>> 
>>>> We're voting on the source distributions available here:
>>>> https://dist.apache.org/repos/dist/dev/tuweni/1.0.0/
>>>> Specifically:
>>>> https://dist.apache.org/repos/dist/dev/tuweni/1.0.0/tuweni-1.0.0-incubating.tgz
>>>> https://dist.apache.org/repos/dist/dev/tuweni/1.0.0/tuweni-1.0.0-incubating.zip
>>>> 
>>>> This is our first release. Please help tease out all the bad bits out of 
>>>> this.
>>>> 
>>>> Cheers,
>>>> 
>>>> Antoine
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [email protected]
>>>> For additional commands, e-mail: [email protected]
>>>> 
>>> 
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [email protected]
>>> For additional commands, e-mail: [email protected]
>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to