On the version debate, I’m comfortable with 0.7.0 as well. Given the nature of the spec some of Tuweni implements, I’m not convinced there won’t be a number of breaking changes to the public API in the near future.
— Steven Schroeder On Wed, May 1, 2019 at 10:47 Antoine Toulme <[email protected]> wrote: > It’s a first release so we can backtrack to 0.7.0 if you like. > > Build: > Fix sources packaging > Add licenses to site files > Add RAT checks in gradle > Consider adding yourself in the pom > > I think that’s mostly it. > > > On May 1, 2019, at 04:59, Michael Wall <[email protected]> wrote: > > > > Thanks Antoine, > > > > I don't have preference on the version number, only that starting with > > 1.0.0 leaves less flexibility. Version 1.0.0 might be fine because the > > project has been used for a while. I just wanted to make sure the > > discussion took place. I'll quote #4 and #5 from > > https://semver.org/#semantic-versioning-specification-semver > > > > 4 - Major version zero (0.y.z) is for initial development. Anything may > > change at any time. The public API should not be considered stable. > > 5 - Version 1.0.0 defines the public API. The way in which the version > > number is incremented after this release is dependent on this public API > > and how it changes. > > > > Anything I can help with on the build? > > > > Mike > > > >> On Tue, Apr 30, 2019 at 11:36 PM Antoine Toulme <[email protected]> > wrote: > >> > >> > >> > >>> On Apr 30, 2019, at 7:00 PM, Michael Wall <[email protected]> wrote: > >>> > >>> Yeah, I am -1 also. > >>> > >>> - Maybe we should do both a bin and src release at the same time and > vote > >>> on both. Should not be any jars in the source artifact > >> OK. > >>> - Rat check is a good idea, should be added to the gradle build > >>> - Need keys file published to > >>> https://dist.apache.org/repos/dist/release/incubator/ < > >> https://dist.apache.org/repos/dist/release/incubator/> > >> This is done just now. > >>> - Would still like to hear if others are comfortable with 1.0.0 being > the > >>> first release > >> I don’t mind too much what version we choose - what would be a good > >> version at this time? > >>> > >>> I can look tomorrow at creating the podling status page. Just saw a > note > >>> from Justin that the clutch build is failing right now, so I didn't > want > >> to > >>> mess with it tonight. > >>> > >>> Mike > >>> > >>> On Tue, Apr 30, 2019 at 12:12 PM Dave Fisher <[email protected]> > >> wrote: > >>> > >>>> Hi - > >>>> > >>>> -1 (binding) - willing to discuss with input from other Mentors. > >>>> > >>>> The source release directory consists of a directory of jar files of > >>>> sources. That’s highly unusual. Why is it done this way? Verifying all > >> of > >>>> these means further unpacking. I did this and the files do have > license > >>>> headers. > >>>> > >>>> sources/net/consensys empty directories exist in all of these source > >> jars. > >>>> > >>>> None of the site files have LICENSEs. > >>>> > >>>> I did the LICENSE check with Apache RAT. > >>>> > >>>> java -jar ~/Development/apache-rat-0.12.jar . > rat-out > >>>> > >>>> Creating a .rat-excludes file is always helpful. > >>>> > >>>> Regards, > >>>> Dave > >>>> > >>>>> On Apr 30, 2019, at 8:43 AM, Dave Fisher <[email protected]> > >> wrote: > >>>>> > >>>>> Hi Antoine, > >>>>> > >>>>> The KEYS file needs to be added to > >>>> https://dist.apache.org/repos/dist/release/incubator/tuweni/. > >>>>> > >>>>> It looks like you have the correct files and the signatures and hash > >> are > >>>> correct. > >>>>> > >>>>> I have not done a full evaluation. > >>>>> > >>>>> Regards, > >>>>> Dave > >>>>> > >>>>>> On Apr 30, 2019, at 8:01 AM, Antoine Toulme <[email protected]> > >>>> wrote: > >>>>>> > >>>>>> Dave, > >>>>>> > >>>>>> Did you have a chance to look at the new artifacts? > >>>>>> > >>>>>>> On Apr 26, 2019, at 20:30, Dave Fisher <[email protected]> > >> wrote: > >>>>>>> > >>>>>>> I’m not seeing any signatures (asc) nor any checksum (sha512). > >>>>>>> > >>>>>>> Did you create a KEYS file? > >>>>>>> > >>>>>>> -1 until these are provided. > >>>>>>> > >>>>>>> Out of pocket until Monday. I can provide details then. > >>>>>>> > >>>>>>> Regards, > >>>>>>> Dave > >>>>>>> > >>>>>>> Sent from my iPhone > >>>>>>> > >>>>>>>> On Apr 26, 2019, at 4:35 PM, Antoine Toulme <[email protected]> > >>>> wrote: > >>>>>>>> > >>>>>>>> We're voting on the source distributions available here: > >>>>>>>> https://dist.apache.org/repos/dist/dev/tuweni/1.0.0/ > >>>>>>>> Specifically: > >>>>>>>> > >>>> > >> > https://dist.apache.org/repos/dist/dev/tuweni/1.0.0/tuweni-1.0.0-incubating.tgz > >>>>>>>> > >>>> > >> > https://dist.apache.org/repos/dist/dev/tuweni/1.0.0/tuweni-1.0.0-incubating.zip > >>>>>>>> > >>>>>>>> This is our first release. Please help tease out all the bad bits > >> out > >>>> of this. > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> > >>>>>>>> Antoine > >>>>>>>> > >> --------------------------------------------------------------------- > >>>>>>>> To unsubscribe, e-mail: [email protected] > >>>>>>>> For additional commands, e-mail: [email protected] > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > --------------------------------------------------------------------- > >>>>>>> To unsubscribe, e-mail: [email protected] > >>>>>>> For additional commands, e-mail: [email protected] > >>>>>>> > >>>>>> > >>>>>> > >>>>>> > --------------------------------------------------------------------- > >>>>>> To unsubscribe, e-mail: [email protected] > >>>>>> For additional commands, e-mail: [email protected] > >>>>>> > >>>>> > >>>>> > >>>>> --------------------------------------------------------------------- > >>>>> To unsubscribe, e-mail: [email protected] > >>>>> For additional commands, e-mail: [email protected] > >>>>> > >>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: [email protected] > >>>> For additional commands, e-mail: [email protected] > >>>> > >>>> > >> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
