Hi -
-1 (binding)
Problems:
- sha512 signatures on bin distributions do not match the archives.
- Apache LICENSE file is missing from src distributions and should include the
Apache License 2.0 text plus the Ethereum MIT License text.
- On the binaries the dependency licenses need to be reviewed. Please list any
that are not AL2.0 and we can review what to do.
See http://www.apache.org/legal/resolved.html
The licenses listed here
http://www.apache.org/legal/resolved.html#category-x must be avoided.
- Archives in source release: (these could be acceptable in source, I’m not
sure.)
./gradle/wrapper/gradle-wrapper.jar
./io/src/test/resources/resourceresolver-test.jar
- The MIT licensed Ethereum reference test files need to be referenced in the
top level NOTICE with the Ethereum copyright notice.
./eth-reference-tests/src/test/resources/eth2.0-tests/LICENSE
./eth-reference-tests/src/test/resources/tests/LICENSE
- A .rat-excludes file should be added to exclude license scans for the
Ethereum reference tests.
./eth-reference-tests/src/test/resources/eth2.0-tests/**
./eth-reference-tests/src/test/resources/tests/src/**
- These test files should be excluded from rat as well. Are these files only
enumerated or is the content tested?
./io/src/test/resources/org/apache/tuweni/io/file/test.txt
./io/src/test/resources/org/apache/tuweni/io/file/resourceresolver/test1.txt
./io/src/test/resources/org/apache/tuweni/io/file/resourceresolver/test2.txt
./io/src/test/resources/org/apache/tuweni/io/file/resourceresolver/subdir/test3.yaml
- What is the licensing of these TOML files?
./toml/src/test/resources/org/apache/tuweni/toml/example-v0.4.0.toml
./toml/src/test/resources/org/apache/tuweni/toml/hard_example.toml
./toml/src/test/resources/org/apache/tuweni/toml/hard_example_unicode.toml
./toml/src/test/resources/org/apache/tuweni/toml/toml-v0.5.0-spec-example.toml
- Probably should add AL to:
./gradlew
I ran the build and had a test failure here:
shouldIterateResourcesOnFileSystemAndInJars()
org.opentest4j.AssertionFailedError: Should have contained 12 items, but got
13:
file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/build/resources/test/org/apache/tuweni/io/file/resourceresolver/
file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/build/resources/test/org/apache/tuweni/io/file/resourceresolver/test1.txt
file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/build/resources/test/org/apache/tuweni/io/file/resourceresolver/test2.txt
file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/build/resources/test/org/apache/tuweni/io/file/resourceresolver/subdir/
file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/build/resources/test/org/apache/tuweni/io/file/resourceresolver/subdir/test3.yaml
jar:file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/src/test/resources/resourceresolver-test.jar!/
jar:file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/src/test/resources/resourceresolver-test.jar!/test4.txt
jar:file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/src/test/resources/resourceresolver-test.jar!/test3.txt
jar:file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/src/test/resources/resourceresolver-test.jar!/subdir/
jar:file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/src/test/resources/resourceresolver-test.jar!/subdir/test3.toml
jar:file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/src/test/resources/resourceresolver-test.jar!/anotherdir/
jar:file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/src/test/resources/resourceresolver-test.jar!/anotherdir/test5.txt
jar:file:/Users/davewave/Development/tuweni/0.7.0/tuweni-src-0.7.0/io/src/test/resources/resourceresolver-test.jar!/anotherdir/test6.yaml
==> expected: <12> but was: <13>
Another thing:
Snapshots on repository.apache.org should not be advertised as part of the
release. These are for ASF and project developers, but not the general user
community. Organizations are getting banned from apache.org for excessive use
of resources like repository.apache.org in their build infrastructure.
> On May 16, 2019, at 5:10 AM, Antoine Toulme <[email protected]> wrote:
>
> I propose we extend the vote until Monday.
>
>> On May 15, 2019, at 18:06, Antoine Toulme <[email protected]> wrote:
>>
>> Ping.
>>
>>> On May 14, 2019, at 10:16 AM, Antoine Toulme <[email protected]> wrote:
>>>
>>> The vote ends tomorrow. I’d like to extend it so we get a chance to get
>>> feedback from mentors. What does everyone think?
>>>
>>>> On May 11, 2019, at 8:17 AM, Antoine Toulme <[email protected]> wrote:
>>>>
>>>> Bumping this thread with my own +1.
>>>>
>>>> I look forward to our mentors feedback.
>>>>
>>>>> On May 10, 2019, at 10:42 AM, [email protected] wrote:
>>>>>
>>>>> +1
>>>>>
>>>>>> On 2019/05/08 22:38:16, Antoine Toulme <[email protected]> wrote:
>>>>>> Sure, signatures are the .asc files here:
>>>>>> https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/
>>>>>> <https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/>
>>>>>>
>>>>>> Checksums are also listed there as .sha512 files.
>>>>>>
>>>>>> The KEYS file is here:
>>>>>> https://dist.apache.org/repos/dist/release/incubator/tuweni/KEYS
>>>>>> <https://dist.apache.org/repos/dist/release/incubator/tuweni/KEYS>
>>>>>>
>>>>>> Please let me know if I should move something.
>>>>>>
>>>>>> Thanks!
>>>>>>
>>>>>> Antoine
>>>>>>
>>>>>>> On May 8, 2019, at 3:35 PM, Dave Fisher <[email protected]> wrote:
>>>>>>>
>>>>>>> Signatures, Hashes and KEYS?
>>>>>>>
>>>>>>>> On May 8, 2019, at 3:33 PM, Antoine Toulme <[email protected]> wrote:
>>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> We're voting on the distributions available here:
>>>>>>>>
>>>>>>>> Specifically, binaries:
>>>>>>>> S/tuweni-bin-0.7.0-incubating.tgz
>>>>>>>> https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-bin-0.7.0-incubating.zip
>>>>>>>> Sources:
>>>>>>>> https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-src-0.7.0-incubating.tgz
>>>>>>>> https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-src-0.7.0-incubating.zip
>>>>>>>> Sample gossip application:
>>>>>>>> https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-gossip-0.7.0-incubating.tgz
>>>>>>>> https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-gossip-0.7.0-incubating.zip
>>>>>>>>
>>>>>>>> This is our first release under the Apache incubator.
>>>>>>>>
>>>>>>>> Please review and vote. The vote is open until Wednesday May 15th.
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>>
>>>>>>>> Antoine
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: [email protected]
>>>>>>>> For additional commands, e-mail: [email protected]
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: [email protected]
>>>>>>> For additional commands, e-mail: [email protected]
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [email protected]
>>>>> For additional commands, e-mail: [email protected]
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [email protected]
>>>> For additional commands, e-mail: [email protected]
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [email protected]
>>> For additional commands, e-mail: [email protected]
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
