Built from source and ran tests. I checked NOTICE and LICENSE files and have the following questions:
1. Why does NOTICE include the following: "In addition, this product includes software developed by Copyright 2018-2019 ConsenSys, Inc." Is there code that is being bundled from ConsenSys or has it all been contributed to ASF? 2. Should we be referencing licenses from dependencies in the NOTICE file? 3. Shouldn't the LICENSE file actually have the text for all the dependencies licenses such as MIT? 4. Should the separate release module for the Gossip app have a source artifact? Apache releases are of source. Any binary release is really a convenience. I do see that the Gossip app is in the source of Tuweni itself - so that may be enough. These are questions from comparing to other projects that I am involved with and may not be strict rules. I would refer you to [1] for details on NOTICE and LICENSE files. If there are actual issues with the above, I don't believe that they are release blockers and that they can be fixed in a future release. Here is my +1. On Fri, May 24, 2019 at 9:55 AM Antoine Toulme <[email protected]> wrote: > The tag is here: > https://github.com/apache/incubator-tuweni/releases/tag/v0.7.0 > > > On May 24, 2019, at 05:11, Jim Jagielski <[email protected]> wrote: > > > > What tag is this based on? > > > >> On May 20, 2019, at 12:39 AM, Antoine Toulme <[email protected]> > wrote: > >> > >> Hi all, > >> > >> We're voting on the distributions available here: > >> > >> Specifically, binaries: > >> > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-bin-0.7.0-incubating.tgz > < > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-bin-0.7.0-incubating.tgz > > > >> > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-bin-0.7.0-incubating.zip > < > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-bin-0.7.0-incubating.zip > > > >> Sources: > >> > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-src-0.7.0-incubating.tgz > < > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-src-0.7.0-incubating.tgz > > > >> > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-src-0.7.0-incubating.zip > < > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-src-0.7.0-incubating.zip > > > >> Sample gossip application: > >> > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-gossip-0.7.0-incubating.tgz > < > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-gossip-0.7.0-incubating.tgz > > > >> > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-gossip-0.7.0-incubating.zip > < > https://dist.apache.org/repos/dist/dev/tuweni/0.7.0/tuweni-gossip-0.7.0-incubating.zip > > > >> > >> This is our first release under the Apache incubator. This is the > second release candidate. > >> > >> Please review and vote. The vote is open until Monday May 27th. > >> > >> Cheers, > >> > >> Antoine > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > >
