See comments inline: > On Jun 16, 2019, at 16:12, Michael Wall <[email protected]> wrote: > > +0 > > I don't want to hold up the first release any longer, but I can't give it > a +1 at this time. > > Good > - Signatures good using > https://dist.apache.org/repos/dist/release/incubator/tuweni/KEYS > > Bad (I could give a +1 with just items 1 and 2) > 1) gradle wrapper needs fixing, jar is included but ./gradlew is not. Actually the jar should not be there either. I have to fix that. > Building with gradle 4.10.3 failed We require gradle 5 (see README). > 2) test jar file > include ./io/src/test/resources/resourceresolver-test.jar. Apologies if > this has been discussed. Yes, that’s used in tests. > 3) got this building with java 11 and java 8. Maybe it is my setup since > others have built the source > ``` >> Task :hobbits:test > > org.apache.tuweni.hobbits.WebSocketTest > testTwoWSConnections(Vertx) FAILED > java.net.BindException > Caused by: java.net.BindException > <=======------> 60% EXECUTING [35m 36s] >> IDLE >> IDLE >> IDLE >> :hobbits:test > 13 tests completed, 1 failed >> :hobbits:test > Executing test > org.apache.tuweni.hobbits.HobbitsTransportTest >> IDLE >> IDLE >> IDLE >> IDLE >> IDLE >> IDLE >> IDLE > ``` Maybe you have something on one of the ports used by those tests. Or tests ran in parallel in a way they deadlocked. > > 4) gradle rat works on the tag, but does not work extracted source > directory. I get this. > ``` > FAILURE: Build failed with an exception. > > * What went wrong: > Task 'rat' not found in root project 'tuweni'. > > * Try: > Run gradle tasks to get a list of available tasks. Run with --stacktrace > option to get the stack trace. Run with --info or --debug option to get > more log output. Run with --scan to get full insights. > > * Get more help at https://help.gradle.org > > BUILD FAILED in 1s > ``` Is this after running gradle setup and using the gradle wrapper? > > What is the plan for binary releases? I see bin, gossip and relayer > artifacts at https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.8.0/ Make gossip and relayer available for download and have folks use them as applications. Binaries is a standard full distribution binary package. > > Mike > >> On Fri, Jun 14, 2019 at 2:36 AM Pierre Smits <[email protected]> wrote: >> >> checked signature and checksums >> >> +1 >> >> Best regards, >> >> Pierre Smits >> >> *Apache Trafodion <https://trafodion.apache.org>, Vice President* >> *Apache Directory <https://directory.apache.org>, PMC Member* >> Apache Incubator <https://incubator.apache.org>, committer >> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges) >> since 2008* >> Apache Steve <https://steve.apache.org>, committer >> >> >> On Thu, Jun 13, 2019 at 9:13 PM Antoine Toulme <[email protected]> >> wrote: >> >>> +1 as well. >>> >>> Folks, please vote. Mentors and IPMC members in particular. >>> >>>> On Jun 12, 2019, at 4:31 PM, Dave Fisher <[email protected]> >> wrote: >>>> >>>> +1 (binding) IPMC vote. >>>> >>>> Signature and checksums are correct. >>>> DISCLAIMER is correct. >>>> LICENSE looks good. >>>> NOTICE looks good. >>>> Ratcheck is good - please make an issue to create a .ratcheck file for >>> the next release. >>>> I excluded ./eth-reference-tests since it has 30,000 json files. >>>> Build works. >>>> >>>> A suggestion for the next release is to write versions of the README >>> that are appropriate to each package. The current README.md is for the >>> GitHub repos. >>>> Also the gradle-wrapper.jar is still included, but that is a minor >> issue. >>>> >>>> Looks good! >>>> >>>> Regards, >>>> Dave >>>> >>>>> On Jun 12, 2019, at 3:21 PM, Antoine Toulme <[email protected]> >>> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> We're voting on the source distributions available here: >>>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.8.0/ >>>>> The release tag is present here: >>>>> https://github.com/apache/incubator-tuweni/releases/tag/v0.8.0 >>>>> >>>>> Please review and vote as appropriate. >>>>> >>>>> The vote is open for at least until Monday of next week. >>>>> >>>>> Cheers, >>>>> >>>>> Antoine >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: [email protected] >>>>> For additional commands, e-mail: [email protected] >>>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >>
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
